fix: remove duplicate bindings#18848
Conversation
lukstbit
left a comment
There was a problem hiding this comment.
@BrayanDSO I find the behavior with the new change confusing. If I set the same gesture for answer(after previously setting the question) the text just says: A: Touch Up. Users might think their question binding was removed. I think it should be presented like choosing Question & Answer where it would just say Touch Up.
|
The proposed behavior of overriding makes sense to me. If I already have a gesture assigned to a control and I want to assign it to both sides, I should select But I get how that may be unexpected. The combining behavior may be unexpected as well if I want to assign the control to a single side then remove the other side afterwards. Maybe the current behavior is the least surprising and we should close this PR. The redundancy issue may not be relevant. |
|
I think the potential confusion after the change(I'm pretty sure this is going to end in a report) outweighs the text duplication. I've also closed the related issue. Sorry for the wasted effort. |
Purpose / Description
Describe the problem or feature and motivation
Fixes
Approach
Instead of combining the bindings, I let it override the binding because I think it is more expected.
How Has This Been Tested?
With an Android 11 emulator, I assigned the same gesture, but with different card sides to see if the side would get overriden.
Checklist
Please, go through these checks before submitting the PR.