Skip to content

refactor(tests): extract utils from NoteTypeTest#18923

Merged
mikehardy merged 1 commit intoankidroid:mainfrom
david-allison:libanki-final
Jul 21, 2025
Merged

refactor(tests): extract utils from NoteTypeTest#18923
mikehardy merged 1 commit intoankidroid:mainfrom
david-allison:libanki-final

Conversation

@david-allison
Copy link
Member

I split this out the 'final' refactor for:

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison added Priority-Low cleanup Non functional change that would improve the code readability labels Jul 20, 2025
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-only I see no reason to delay, would love to finish the refactor before any branch

@mikehardy mikehardy added this pull request to the merge queue Jul 21, 2025
@mikehardy mikehardy added the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jul 21, 2025
Merged via the queue into ankidroid:main with commit 053a635 Jul 21, 2025
13 checks passed
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jul 21, 2025
@github-actions github-actions bot added this to the 2.22 release milestone Jul 21, 2025
@david-allison david-allison deleted the libanki-final branch July 21, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Non functional change that would improve the code readability Priority-Low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants