fix: hide save button in fragmented activity to prevent duplication

[Haz3-jolt]

Purpose / Description

• Hides the save button from NoteEditorFragment in cardBrowser to prevent duplication

Fixes

• Fixes Duplicate Save Note buttons when NoteEditor is in X-Large CardBrowser and preview icon missing #18921

Approach

• The cardBrowser already has a 'save_note' being added, and noteEditorFragment adds another one.
• Here we introduce a check to prevent additional 'save_note' buttons from being added.
• This occurred after the NoteEditor was separated into the NoteEditorActivity.
• Since NoteEditorFragment is a MenuProvider we do not need onCreateMenu anymore.

How Has This Been Tested?

Checklist

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[david-allison]

I don't feel the issue, PR or commit message explain why this is occurring.

What's producing the other save button? Why are we removing it from the Note Editor?

[Haz3-jolt]

I don't feel the issue, PR or commit message explain why this is occurring.

What's producing the other save button? Why are we removing it from the Note Editor?

I've added some context in the PR, I'll also do so in the commit message

[david-allison]

I'd remove adding the menu item 'action_save' from the Browser. It should be a responsibility of the note editor.

The Browser should instead override the action_save, instead of passing it down to the fragment

[Arthur-Milchior]

In the commit message "save note" and "preview" should be quoted. Or even you should state that it remove the menu entry named "save note" and "preview". As those are verbs that are used as noun, it makes the sentence very confusing otherwise.

I really don't understand what the last line mean. I have now idea which check you're referring to. How could a check disappear.

I appreciate that your commit message are longer than a single line, but it's still hard to follow.

[Haz3-jolt]

Should have a more clear message rn! Thanks for the heads up, it was a lot more obvious to me because I worked on it!
Hindsight blinded me ig 😆

[david-allison]

Ok, consider making the title ~50 chars:

fix(card-browser): remove duplicate menu items

[lukstbit]

Let's get this in...