Skip to content

Update 10-preferences.xml#18956

Merged
lukstbit merged 1 commit intoankidroid:mainfrom
NayanKaushik25:nayan_kaushik
Jul 31, 2025
Merged

Update 10-preferences.xml#18956
lukstbit merged 1 commit intoankidroid:mainfrom
NayanKaushik25:nayan_kaushik

Conversation

@NayanKaushik25
Copy link
Contributor

changed "media" to "audio" to specify audio/sound files.

Purpose / Description

Same as the PR Title

Fixes

Approach

The issue was solved by changing the term "media" to "audio" to improve the specificity of the files being discussed in the xml.

changed "media" to "audio" to specify audio/sound files.
@welcome
Copy link

welcome bot commented Jul 24, 2025

First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible.

@github-actions
Copy link
Contributor

Important

Maintainers: This PR contains Strings changes

  1. Sync Translations before merging this PR and wait for the action to complete
  2. Review and merge the auto-generated PR in order to sync all user-submitted translations
  3. Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review

Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If video files are also supported, doesn't media capture it better than audio?
And I believe video files are supported.

@david-allison
Copy link
Member

@mikehardy we're getting complaints that <img> tags are no longer supported. Any prescriptive suggestions?

I suppose our choices:

  • Use [sound] (and maybe TTS)
  • Use "Audio/Video"
  • Do nothing

@mikehardy
Copy link
Member

I don't think I understand the problem well enough from perspective of 1) what used to be supported 2) what desktop supports 3) what we support now in order to say anything

knowing what fills in those three items would help reason about it. Is there some issue logged about it?

@david-allison
Copy link
Member

david-allison commented Jul 25, 2025

We provide a setting with the summary:

Display media filenames in the card browser question/answer fields

But this now only handles [sound:] tags:

We now use the Anki backend to render the question/answer. I don't believe that the backend supports stripping img tags any more. Since we just get the processed HTML back, we can't easily reverse the src

We also have a very tight execution budget due to rendering on the UI thread in a RecyclerView for smooth scrolling, so can't do anything interesting here


Damien said that [stripping img tags] was not a priority because the user can already customize the question and answer format used by the browser.

@NayanKaushik25
Copy link
Contributor Author

Have you decided what type of media files are supported as of now?

@mikehardy
Copy link
Member

Okay, sounds like sound files are the only ones we can show or not, so the string change here seems fine
Not sure if there is anything more we can do for img files, user complaints or not, if backend doesn't support it
Can revert this change if/when backend ever supports more than sound: tag stripping

Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikehardy mikehardy added the Needs Second Approval Has one approval, one more approval to merge label Jul 30, 2025
@mikehardy mikehardy requested a review from david-allison July 30, 2025 17:36
@david-allison david-allison removed the Needs Second Approval Has one approval, one more approval to merge label Jul 30, 2025
@lukstbit lukstbit added this pull request to the merge queue Jul 31, 2025
Merged via the queue into ankidroid:main with commit 7b6f815 Jul 31, 2025
13 checks passed
@github-actions github-actions bot added this to the 2.23 release milestone Jul 31, 2025
@github-actions
Copy link
Contributor

Maintainers: Please Sync Translations to produce a commit with only the automated changes from this PR.

Read more about updating strings on the wiki,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove image reference in 'Display filenames in card browser' summary

4 participants