Skip to content

card type retention when copying #19384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+34 −2
Open

card type retention when copying #19384

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
661c204
feat(note-editor): Add EXTRA_NOTE_TYPE_ID constant
Aryan171 Oct 29, 2025
5a88e2e
feat(note-editor): Allow specifying note type when adding a note
Aryan171 Oct 29, 2025
0f02bd7
feat(note-editor): Set note type when adding a new note
Aryan171 Oct 29, 2025
cb706e8
feat(note-editor): specify note type when copying note
Aryan171 Oct 29, 2025
a004f54
test(NoteEditor): Use `setCurrentlySelectedNoteType` in builder
Aryan171 Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions AnkiDroid/src/main/java/com/ichi2/anki/NoteEditorFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -842,6 +842,27 @@ class NoteEditorFragment :
if (addNote) {
noteTypeSpinner!!.onItemSelectedListener = SetNoteTypeListener()
requireAnkiActivity().setToolbarTitle(R.string.menu_add)

// set the note type
val noteTypeId: Long? =
if (!allNoteTypeIds.isNullOrEmpty()) {
requireArguments().getLong(
EXTRA_NOTE_TYPE_ID,
allNoteTypeIds!![0],
)
} else {
null
}
val noteTypeIdIndex: Int =
if (noteTypeId != null && !allNoteTypeIds.isNullOrEmpty()) {
allNoteTypeIds!!.indexOfFirst { it == noteTypeId }.let {
if (it == -1) 0 else it
}
} else {
0
}
noteTypeSpinner!!.setSelection(noteTypeIdIndex)

// set information transferred by intent
var contents: String? = null
val tags = requireArguments().getStringArray(EXTRA_TAGS)
Expand Down