Skip to content

Conversation

@gurnoorpannu
Copy link
Contributor

Purpose / Description

Replacing the deprecated numeric ProgressDialog with a modern Material Design 3 Circular Progress Dialog that displays percentage progress

Fixes

Approach

Implemented a new CircularProgressDialog class using AlertDialog and CircularProgressIndicator.

Integrated this dialog into existing coroutine helper methods (CoroutineHelpers.kt) to replace the old ProgressDialog.

Updated progress updates to display percentage values instead of “current/total”.

Improved accessibility with dynamic content descriptions for determinate and indeterminate states.

Added new layout resource dialog_circular_progress.xml for the dialog UI.

Introduced new string resources for progress text and accessibility descriptions.

How Has This Been Tested?

Testing while syncing the data with Ankiweb
--->

@github-actions
Copy link
Contributor

Important

Maintainers: This PR contains Strings changes

  1. Sync Translations before merging this PR and wait for the action to complete
  2. Review and merge the auto-generated PR in order to sync all user-submitted translations
  3. Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review

Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please post screenshots/videos.

This change unnecessarily changes the standard dialog. Did you test this?

Screenshot 2025-11-12 at 17 09 57 Screenshot 2025-11-12 at 17 08 02

@david-allison david-allison added the Needs Author Reply Waiting for a reply from the original author label Nov 12, 2025
@gurnoorpannu
Copy link
Contributor Author

Please post screenshots/videos.

This change unnecessarily changes the standard dialog. Did you test this?

Screenshot 2025-11-12 at 17 09 57 Screenshot 2025-11-12 at 17 08 02

I’m tied up with exams and college work right now, but I’ll share the screenshots and updates in a few days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Author Reply Waiting for a reply from the original author Strings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UX] Show progress in percentage

2 participants