Fix repairCollection requiring the database to be opened#19903
Open
Alex7D3 wants to merge 1 commit intoankidroid:mainfrom
Open
Fix repairCollection requiring the database to be opened#19903Alex7D3 wants to merge 1 commit intoankidroid:mainfrom
repairCollection requiring the database to be opened#19903Alex7D3 wants to merge 1 commit intoankidroid:mainfrom
Conversation
Changes the method to accept a file instead of a collection object. Obtaining the collection object requires opening the database, which will propagate an exception if the collection file is indeed corrupt, preventing the repair from executing.
Contributor
Author
|
Probably want to get the new test in #19692 merged first to run against this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
See #19692.
Accessing the collection object to pass into
repairCollectionnecessarily requires opening the database (such as usingwithColscope), which will throw an exception if the collection is corrupt, preventing the repair from executing.Fixes
repairCollectionattempts database open and throws an exception. #19902Approach
Changes the method to accept a
Fileinstead of aCollection.How Has This Been Tested?
Standard test suite.
Learning (optional, can help others)
Describe the research stage
Links to blog posts, patterns, libraries or addons used to solve this problem
Checklist
Please, go through these checks before submitting the PR.