refactor(whiteboard): extract toolbar into a separate view #19979
+360
−287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrayanDSO
added
Needs Review
Blocked by dependency
BrayanDSO
force-pushed
the
feat/whiteboard-toolbar
branch
from
b457896 to
8903f52
Compare
BrayanDSO
removed
Blocked by dependency
david-allison
approved these changes
Jan 6, 2026
AnkiDroid/src/main/java/com/ichi2/anki/ui/windows/reviewer/whiteboard/BrushAdapter.kt
Show resolved
Hide resolved
AnkiDroid/src/main/java/com/ichi2/anki/ui/windows/reviewer/whiteboard/WhiteboardToolbar.kt
Show resolved
Hide resolved
david-allison
added
Needs Second Approval
BrayanDSO
force-pushed
the
feat/whiteboard-toolbar
branch
from
8903f52 to
b95aad5
Compare
Also 1. made `fragment_whiteboard` a FrameLayout, so changing the toolbar position is wayyyyyyyyyy easier with layout gravity 2. Used a `RecyclerView` instead of separate Horizontal and Vertical scrollViews, which should be more performant
mikehardy
approved these changes
Jan 7, 2026
| constraintSet.constrainHeight(containerId, ConstraintSet.WRAP_CONTENT) | ||
| constraintSet.setMargin(containerId, ConstraintSet.START, 8 * dp) | ||
| } | ||
| @SuppressLint("RtlHardcoded") |
Member
There was a problem hiding this comment.
🧐 , 👍 justified
all looks good
mikehardy
added
Pending Merge
github-actions
bot
removed
the
Pending Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose / Description
The whiteboard was so complex and big that I didn't make the best choices for part of its code design. So now, with a fresher mind, I'm trying to make it more pleasant to work with.
How Has This Been Tested?
Screen_recording_20251230_053103.mp4
Checklist
Please, go through these checks before submitting the PR.