-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Enhancement (Card Browser): Tap and drag scrollbar #19980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dd68900 to
e95b2f8
Compare
| .toInt() | ||
| .coerceIn(0, adapter.itemCount - 1) | ||
| try { | ||
| recyclerView?.smoothScrollToPosition(targetPosition) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
smooth scrolling renders all rows between the current and target position.
You probably don't want this, we don't want dropped frames on this screen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh ok understood!
7905e0a to
4147bcb
Compare
david-allison
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation feels reasonable (heavy GCs, but that's somewhat expected as we're loading pages of results).
4147bcb to
0232cf9
Compare
0232cf9 to
e76568f
Compare
david-allison
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
Purpose / Description
This change lets the user tap anywhere on the scrollbar to skip to that position in the list and continue dragging.
Fixes
How Has This Been Tested?
Screen_recording_20251230_183527.webm
Checklist
Please, go through these checks before submitting the PR.