Skip to content

Conversation

@ShaanNarendran
Copy link
Contributor

@ShaanNarendran ShaanNarendran commented Dec 30, 2025

Purpose / Description

This change lets the user tap anywhere on the scrollbar to skip to that position in the list and continue dragging.

Fixes

How Has This Been Tested?

Screen_recording_20251230_183527.webm

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

.toInt()
.coerceIn(0, adapter.itemCount - 1)
try {
recyclerView?.smoothScrollToPosition(targetPosition)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smooth scrolling renders all rows between the current and target position.

You probably don't want this, we don't want dropped frames on this screen

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh ok understood!

@david-allison david-allison added the Needs Author Reply Waiting for a reply from the original author label Jan 5, 2026
@ShaanNarendran ShaanNarendran force-pushed the Scrollbar-Fix branch 2 times, most recently from 7905e0a to 4147bcb Compare January 5, 2026 12:49
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation feels reasonable (heavy GCs, but that's somewhat expected as we're loading pages of results).

Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Author Reply Waiting for a reply from the original author Needs Review labels Jan 5, 2026
@BrayanDSO BrayanDSO added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Jan 6, 2026
@BrayanDSO BrayanDSO added this pull request to the merge queue Jan 6, 2026
Merged via the queue into ankidroid:main with commit ca95728 Jan 6, 2026
15 checks passed
@github-actions github-actions bot added this to the 2.24 release milestone Jan 6, 2026
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jan 6, 2026
@ShaanNarendran ShaanNarendran deleted the Scrollbar-Fix branch January 6, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scrollbar should jump to clicked location

5 participants