Skip to content

Conversation

@david-allison
Copy link
Member

Purpose / Description

Tests marked as @Flaky were still run if they were in JvmTest

Fixes

Approach

Apply IgnoreFlakyTestsInCIRule

How Has This Been Tested?

It's test-only: if CI passes, I'm happy

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison changed the title fix: @Flaky not being applied tests: fix @Flaky not being applied Jan 5, 2026
@david-allison
Copy link
Member Author

david-allison commented Jan 5, 2026

Awaiting https://github.com/david-allison/Anki-Android/actions/runs/20703089360

EDIT: I force pushed to change the order of the throw to come after the emit in a prior commit, I don't believe this will materially impact flakiness (and if it does, our scheduled job will catch it)

Follow on from 2cc3bfb

This didn't flag the error I expected it to flag in
 `PreviewerViewModelTest`
`ignoreFlakyTests` was only on RobolectricTest

Fixes 19934
Flaky was moved to `common`
@david-allison david-allison marked this pull request as ready for review January 5, 2026 03:25
@BrayanDSO BrayanDSO added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Jan 5, 2026
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@mikehardy mikehardy added this pull request to the merge queue Jan 6, 2026
@mikehardy mikehardy removed the Needs Second Approval Has one approval, one more approval to merge label Jan 6, 2026
Merged via the queue into ankidroid:main with commit 274bbe1 Jan 6, 2026
15 checks passed
@github-actions github-actions bot added this to the 2.24 release milestone Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests need de-flaking

3 participants