Skip to content

chore: convert ReviewerMenuSettingsFragment to ViewBinding #20008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukstbit merged 1 commit into from
Jan 11, 2026
Merged

chore: convert ReviewerMenuSettingsFragment to ViewBinding #20008

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions AnkiDroid/src/main/java/com/ichi2/anki/preferences/reviewer/ReviewerMenuSettingsFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@ import androidx.fragment.app.Fragment
import androidx.lifecycle.lifecycleScope
import androidx.recyclerview.widget.ItemTouchHelper
import androidx.recyclerview.widget.LinearLayoutManager
import androidx.recyclerview.widget.RecyclerView
import com.google.android.material.appbar.MaterialToolbar
import com.google.android.material.snackbar.Snackbar
import com.ichi2.anki.R
import com.ichi2.anki.databinding.PreferencesReviewerMenuBinding
import com.ichi2.anki.snackbar.showSnackbar
import com.ichi2.anki.utils.ext.sharedPrefs
import dev.androidbroadcast.vbpd.viewBinding
import kotlinx.coroutines.launch

class ReviewerMenuSettingsFragment :
Expand All @@ -37,22 +37,22 @@ class ReviewerMenuSettingsFragment :
ActionMenuView.OnMenuItemClickListener {
private lateinit var repository: ReviewerMenuRepository

private val binding by viewBinding(PreferencesReviewerMenuBinding::bind)

override fun onViewCreated(
view: View,
savedInstanceState: Bundle?,
) {
super.onViewCreated(view, savedInstanceState)
repository = ReviewerMenuRepository(sharedPrefs())
setupRecyclerView(view)
view.findViewById<MaterialToolbar>(R.id.toolbar).setNavigationOnClickListener {
setupRecyclerView()
binding.toolbar.setNavigationOnClickListener {
requireActivity().onBackPressedDispatcher.onBackPressed()
}
view.findViewById<ReviewerMenuView>(R.id.reviewer_menu_view).apply {
setOnMenuItemClickListener(this@ReviewerMenuSettingsFragment)
}
binding.reviewerMenuView.setOnMenuItemClickListener(this@ReviewerMenuSettingsFragment)
}

private fun setupRecyclerView(view: View) {
private fun setupRecyclerView() {
val menuItems = repository.getActionsByMenuDisplayTypes()

fun section(displayType: MenuDisplayType): List<ReviewerMenuSettingsRecyclerItem> =
Expand All @@ -72,7 +72,7 @@ class ReviewerMenuSettingsFragment :
}
}

view.findViewById<RecyclerView>(R.id.recycler_view).apply {
binding.recyclerView.apply {
setHasFixedSize(true)
layoutManager = LinearLayoutManager(requireContext())
this.adapter = adapter
Expand Down Expand Up @@ -108,7 +108,7 @@ class ReviewerMenuSettingsFragment :
)

lifecycleScope.launch {
val menu = requireView().findViewById<ReviewerMenuView>(R.id.reviewer_menu_view)
val menu = binding.reviewerMenuView
menu.clear()
menu.addActions(alwaysShowActions, menuOnlyActions)
menu.setFlagTitles()
Expand Down