fix(note-editor): retain note type when copying and preserve field data

[Aryan171]

Purpose / Description

This PR ensures that the Note Type is correctly retained when copying a note in the Note Editor. Additionally, this PR addresses the field blanking bug where fields were blanked when changing to a note type with less number of fields and then changing back to the original note type

Fixes

• Fixes [Bug] Actual card type must be respected during copy #8188

Approach

This implementation incorporates the architectural refactor provided by david-allison via a patch in the previously closed pr #19384. To solve the field blanking bug, I implemented a caching mechanism that preserves field content during Note Type transitions.

How Has This Been Tested?

Unit Tests:
copyNoteCopiesNoteType: Verifies that the new note retains the original note's type.

changing note type preserves and restores field contents: Verifies that switching to a 3-field Note Type and back to a 5-field Note Type does not clear the 3rd, 4th and 5thfield's text.

Manual Verification done on android 15 phone

Screen recordings

https://github.com/user-attachments/assets/f3c317b1-d2d9-47df-b61b-7e8b939164db
https://github.com/user-attachments/assets/85310e7f-8c31-459c-8e81-0e25862bf00e

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[david-allison]

This looks wrong.

How did "copy" work previously, as it works if you don't change the note type back and forth

[david-allison]

This isn't the bug I listed

[david-allison]

This still isn't the bug I listed, could you also add a test for the bug I provided.

This test is fine if there's an additional bug while adding

[Aryan171]

This test checks for field text retention in the add mode by switching from 3 fields -> 2 fields -> 3 fields. I have verified that:

When switching 3 -> 2, the first two fields are preserved.

When switching back 2 -> 3, the third field is restored from memory: assertThat("Field ${i + 1} should be restored from memory", fields[i], equalTo(text))

Since the bug report mentions the final field being blanked during these steps, this test was designed to catch that exact bug. I might be missing something small in how the bug was reported, could you clarify if you're looking for a specific test case for the edit mode as well even if the failure is in the add mode only?

edit: I’ve confirmed this test passes with my fix and fails on the current codebase

[Aryan171]

Thanks for the feedback. I have changed the caching logic as it was needlessly complex. I also changed the 5 field note type test to 3 field as you originally listed.
Earlier when you copied notes, the note type was the note type of the note you last used i.e. the note you were just editing. This is correct by accident the bug reveals itself only when the note type of the last used card and the note type of the card you want to copy changes which happens when you change the note type from the note editor.

I also thought of doing note type change the same way is done in EditNoteTypeListener but that would require a lot of work as in the "add mode" the data is only stored in the UI and there is no source of truth as there is in the "edit mode", at last I decided on using a simple cache which will be used to rewrite the lost fields as it is the easiest fix and will not increase the complexity much. I'm happy to adjust if there's a better approach.

[david-allison]

This still looks wrong. The cache shouldn't be necessary

How did "copy" work previously, as it works if you don't change the note type back and forth?

[Aryan171]

The cache isn't used for the "copy note type bug". It fixes the field blanking bug

[david-allison]

The bug doesn't occur when in 'change note type' mode, field data is retained.

I suspect the same solution would work here.

If there is a bug, add a test

[Aryan171]

I have removed the cache now. The field blanking was caused because in the add mode, (1)editorNote is not synced with the UI when note type is changed and (2) when the note type is actually changed all the fields in the editorNote are never copied.