Skip to content

Conversation

@gurnoorpannu
Copy link
Contributor

Purpose / Description

reverted the v4 <-> v6 changes in pr #20004

Fixes

Approach

How does this change address the problem?

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration (SDK version(s), emulator or physical, etc)

Learning (optional, can help others)

Describe the research stage

Links to blog posts, patterns, libraries or addons used to solve this problem

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

- Add concurrency control to prevent overlapping runs
- Cancel in-progress runs when new one is triggered
- Enforce minimum 30-minute gap between syncs (not fixed delay)
- Check last commit time on i18n_sync branch
- Calculate remaining wait time dynamically
- Proceed immediately if >= 30 minutes have passed
- Add defensive guard against negative sleep values
- Update timeout from 20 to 50 minutes

Fixes: ankidroid#19994
@gurnoorpannu gurnoorpannu changed the title CI: prevent redundant translation sync runs and enforce 30-minute gap prevent redundant translation sync runs and enforce 30-minute gap Jan 7, 2026
@david-allison
Copy link
Member

I closed #20004 because I didn't trust the rest of the implementation, given the review comments, regardless of whether the dependency should be downgraded.

You also haven't stated how you tested this

@gurnoorpannu
Copy link
Contributor Author

I closed #20004 because I didn't trust the rest of the implementation, given the review comments, regardless of whether the dependency should be downgraded.

You also haven't stated how you tested this
can you like explain a little what exactly are you expecting

@david-allison
Copy link
Member

On this issue: nothing further.

Getting GitHub Actions wrong is a huge time sink for us, and this is too 'high risk' for me to see to completion:

  • The PR template hasn't been filled out
  • There's a lot of code
  • There's no evidence of testing
  • The discussion on the last PR is a knock to my confidence that this change is understood

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Schedule Sync translations action to run 30 minutes after the last one.

2 participants