Skip to content

Conversation

@BrayanDSO
Copy link
Member

if Show answer buttons was disabled, the timer was visible even if disabled

Discovered by looking over the reviewer screenshot tests

Approach

For some reason, a ConstraintLayout Flow resets its children visibility if a new constraint is applied, such as when the answer buttons are hidden on tablets.

How Has This Been Tested?

Sreenshot semi-automated tests

Details Phone_toolbar=BOTTOM_frameStyle=BOX_buttons=false Tablet_toolbar=TOP_frameStyle=BOX_buttons=true Phone_toolbar=BOTTOM_frameStyle=BOX_buttons=true Phone_toolbar=NONE_frameStyle=BOX_buttons=false Phone_toolbar=NONE_frameStyle=BOX_buttons=true Phone_toolbar=TOP_frameStyle=BOX_buttons=false Phone_toolbar=TOP_frameStyle=BOX_buttons=true Tablet_toolbar=BOTTOM_frameStyle=BOX_buttons=false Tablet_toolbar=BOTTOM_frameStyle=BOX_buttons=true Tablet_toolbar=NONE_frameStyle=BOX_buttons=false Tablet_toolbar=NONE_frameStyle=BOX_buttons=true Tablet_toolbar=TOP_frameStyle=BOX_buttons=false

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@BrayanDSO BrayanDSO force-pushed the fix/big-timer branch 2 times, most recently from 13b8940 to decaefe Compare January 7, 2026 20:31
if `Show answer buttons` was disable, the timer was visible even if disabled
@BrayanDSO
Copy link
Member Author

Gonna yolo this one. It's well tested and merging it spares me some time on other PRs.

I'm on the area, so I take full responsability here.

@BrayanDSO BrayanDSO merged commit 6213d7a into ankidroid:main Jan 7, 2026
15 checks passed
@github-actions github-actions bot added this to the 2.24 release milestone Jan 7, 2026
@mikehardy
Copy link
Member

Nothing like a new testing modality to expose a bunch of new issues that weren't even known before - kudos for the screenshot infra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants