Skip to content

chore: convert ColumnSelectionDialogFragment to ViewBinding #20153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BrayanDSO merged 1 commit into from
Jan 21, 2026
Merged

chore: convert ColumnSelectionDialogFragment to ViewBinding #20153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions AnkiDroid/src/main/java/com/ichi2/anki/browser/ColumnSelectionDialogFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,14 @@ import android.view.ViewGroup
import android.widget.ArrayAdapter
import android.widget.LinearLayout
import android.widget.ListView
import android.widget.TextView
import androidx.appcompat.app.AlertDialog
import androidx.core.os.BundleCompat
import androidx.core.os.bundleOf
import androidx.fragment.app.DialogFragment
import androidx.fragment.app.activityViewModels
import androidx.lifecycle.lifecycleScope
import com.ichi2.anki.R
import com.ichi2.anki.databinding.ItemColumnSelectionBinding
import com.ichi2.utils.dp
import com.ichi2.utils.setPaddingRelative
import kotlinx.coroutines.launch
Expand Down Expand Up @@ -74,17 +74,22 @@ class ColumnSelectionDialogFragment : DialogFragment() {
convertView: View?,
parent: ViewGroup,
): View {
val view = convertView ?: layoutInflater.inflate(R.layout.item_column_selection, parent, false)
val binding =
if (convertView != null) {
ItemColumnSelectionBinding.bind(convertView)
} else {
ItemColumnSelectionBinding.inflate(layoutInflater, parent, false)
}

val column = getItem(position)

view.findViewById<TextView>(R.id.column_title).text =
binding.columnTitle.text =
column?.label ?: getString(R.string.no_columns_available)

view.findViewById<TextView>(R.id.column_example).text =
binding.columnExample.text =
if (column?.sampleValue.isNullOrBlank()) "-" else column.sampleValue

return view
return binding.root
}
}
listView.adapter = adapter
Expand Down