Fix #19225: Fix undo error after editing note template #20181
Closed
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you reproduce the bug in v2.24.0alpha4? I couldn't reproduce it. |
Contributor
Author
|
@ZornHadNoChoice You are right. I just tested it again on the latest main branch without my changes, and I cannot reproduce the crash either. It seems this was fixed recently by another PR. I had made the changes earlier but raise the PR today. |
Contributor
Author
|
I'm closing this as this issue is no longer exist #19225 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Fixes #19225
When editing a note template in the new reviewer, the queue state wasn't successfully updating, which caused errors when trying to undo.
Approach
The ReviewerViewModel wasn't refreshing the queue state when
changes.noteTextoccurred. I added a call to updateCurrentCard() in that block to ensure the local state stays in sync with the backend.How Has This Been Tested?
Tested manually on the New Study Screen:
Previously this errored out ("card modified without updating queue"), now it works correctly.
538358000-7175f074-ab0e-4c44-a54b-5e34ee3c2a27.mp4
Checklist