Constrain simulator graph width to fix oversized text#4548
Open
chrislongros wants to merge 1 commit intoankitects:mainfrom
Open
Constrain simulator graph width to fix oversized text#4548chrislongros wants to merge 1 commit intoankitects:mainfrom
chrislongros wants to merge 1 commit intoankitects:mainfrom
Conversation
chrislongros
force-pushed
the
fix/simulator-ui-refinements
branch
2 times, most recently
from
6480a24 to
5808da5
Compare
Author
|
Before: After: |
Partial fix for ankitects#4168 The simulator modal uses max-width: 100vw, causing the SVG graph to stretch across the full viewport. Since text inside the SVG scales with the viewBox, axis labels and legend text appear disproportionately large compared to surrounding UI elements. Adding max-width to svg-container keeps the graph at a readable size consistent with graphs on the statistics page.
chrislongros
force-pushed
the
fix/simulator-ui-refinements
branch
from
5808da5 to
1d28101
Compare
Collaborator
|
This doesn't look good with bigger screens: 
We don't need to be consistent with the stats page here, as we only have a single graph, and having it fill available space is better for readability. Might be better to set a smaller font-size instead - See Graph.svelte for reference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial fix for #4168 (complements #4535 which addresses the border-radius)
The FSRS simulator modal uses
max-width: 100vw, causing the SVG graph to stretch across the full viewport. Since text inside the SVG scales with the viewBox, axis labels and legend text appear disproportionately large compared to surrounding UI elements.This adds
max-width: 800pxto.svg-container, keeping the graph at a readable size consistent with the statistics page graphs.Before/after screenshots to follow in comments.