update deckbrowser layout to support Homerow #4553
update deckbrowser layout to support Homerow #4553villegascmarco wants to merge 2 commits intoankitects:mainfrom
Conversation
|
Some add-ons rely on the decks list being a table, so this will potentially cause issues. Maybe we can solve this by setting ARIA roles instead? The main screen will be eventually overhauled, but we want to avoid UI changes until then. |
|
I found this on the internet: Let me see if I understand well: this PR updates |
|
@abdnh I made a proof o concept and seems like is not the right approach , third party apps do not work when using ARIA role set to "table" either. The change is pretty basic in my opinion, shouldn't be a big deal to update the target in the add-ons to be a div with a certain class instead of a |
|
A lot of add-ons that touch the deck list depend on the table structure (e.g. Enhance main window), as Anki doesn't have high-level hooks to customize the UI. It's hard to justify additional work for add-ons for little benefit at this stage (You can already perform most actions using built-in shortcuts), but we can revisit this later. |
update deck browser layout to support keyboard shortcut from third parties.
Some third-party keyboard shortcut and hinting tools (like Homerow) were unable to detect deck entries in the Deck Browser because the list was rendered using a
<table>. In Qt WebEngine, interactive elements inside tables are not always exposed correctly to accessibility and automation APIs.This change updates the Deck Browser layout to use
<div>-based rows instead, preserving the same visual appearance while making deck links and buttons consistently selectable by external keyboard shortcut tools.Before
Now