fix(tui): auto-scroll textarea cursor when typing long prompts #10482
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add markDirty() and requestRender() calls to the onContentChange handler to keep the cursor visible when typing beyond the visible area. This matches the pattern already used in the onPaste and TuiEvent.PromptAppend handlers. Fixes anomalyco#10401 Co-Authored-By: Claude <[email protected]>
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Found a potentially related PR: PR #10449: fix(tui): resolve textarea flickering when pasting long text in question prompt Why it's related: Both PRs address textarea rendering issues in the TUI. PR #10449 fixes flickering when pasting long text, while PR #10482 fixes cursor auto-scrolling when typing long prompts. Both likely involve similar viewport/layout recalculation mechanisms ( You may want to check if these can be combined or if they address different aspects of the same component issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the textarea cursor not auto-scrolling when typing long prompts that exceed the visible area (maxHeight of 6 lines).
When typing beyond the visible area, the cursor would move but the viewport wouldn't follow, leaving the text invisible and causing black/empty spaces to appear.
How did you verify your code works?
The fix adds
markDirty()andrequestRender()calls to theonContentChangehandler, matching the pattern already used in:onPastehandler (lines 926-929)TuiEvent.PromptAppendhandler (lines 98-100)This ensures the layout is recalculated and the viewport syncs with cursor position on every keystroke.
Fixes #10401
🤖 Generated with Claude Code