feat(formatters): add laravel pint as a .php formatter
#7312
+16
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
rekram1-node
reviewed
Jan 8, 2026
| async enabled() { | ||
| const items = await Filesystem.findUp("composer.json", Instance.directory, Instance.worktree) | ||
| for (const item of items) { | ||
| const json = await Bun.file(item).json() |
Collaborator
There was a problem hiding this comment.
just to be defensive maybe do a .catch(() => undefined) and return false if json is undefined?
Author
There was a problem hiding this comment.
@rekram1-node there are two occurrences of code exactly like this in this file, and neither of them does that check. so i was just trying to be consistent. do you still want me to apply that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yo, this pull request adds laravel pint as a
.phpformatter, and it only runs if it’s explicitly specified incomposer.json, as expected.note: although pint is under the laravel organization, it’s framework-agnostic and works with any php project.