Switch tsconfig to NodeNext module resolution#855
Merged
Conversation
|
In case it's useful this should fix the upstream for bun-ffi-structs (anomalyco/bun-ffi-structs#3) and bun-webgpu (kommander/bun-webgpu#5). Happy to make changes or work more on those or these pull request if helpful! |
Prevent regressions where extensionless imports break consumers using NodeNext or Node's ESM loader. tsconfigs override back to "bundler" because bun-ffi-structs and bun-webgpu don't export NodeNext-compatible types yet. Change this once @kommander fixes upstream Close: #843
simonklee
force-pushed
the
node-module-res
branch
from
022acdd to
e1c7634
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent regressions where extensionless imports break consumers using NodeNext
or Node's ESM loader.
tsconfigs override back to "bundler" because bun-ffi-structs and bun-webgpu
don't export NodeNext-compatible types yet.
Change this once @kommander fixes upstream. I think we can merge this pr now and update the last things once you've updated upstream.
Close: #843