Support Escapable Characters in Prefix With BATs Testing#347
Merged
anothrNick merged 5 commits intoanothrNick:masterfrom Aug 22, 2025
Merged
Conversation
Contributor
Author
|
@anothrNick When you get the chance could you take a look please. |
anothrNick
approved these changes
Aug 11, 2025
|
@anothrNick Thanks for approving this. When you get a chance, could you please also merge and release this change? |
Contributor
Author
|
@anothrNick Do you have the ability to approve the workflows for this PR, or can you point us in the direction of a maintainer who can please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
As outlined in this ticket (#342) forward slash is not supported for prefixes because of a conflict with
sed. Forward slash in particular is common in tagging especially in a monorepo with multiple deployable entities.I've updated the
sedcommand to use semicolon;as a separator to support the large majority of use cases.In this change I have also introduced a new test framework for the project BATs to support testing this change. The penultimate commit pushed the tests that verified that the
/was not supported in a prefix, and the last commit actually fixed it (making the tests pass).To support testing these particular changes and to avoid too much setup, I've passed in the
DRY_RUNflag which allows us to test the functionality we need, however in future tests (if you decide to adopt this approach) it can be omited and committed to a repo.Breaking Changes
Do any of the included changes break current behaviour or configuration?
How changes have been tested
/is parsed and bumpedtest/) is incremented using this change:List any unknowns