Skip to content

Conversation

@Clemsazert
Copy link
Contributor

@Clemsazert Clemsazert commented Nov 7, 2025

🔎 Détails

  • Refactoring de la stratégie de conversion CISU pour être en mesure de traiter les différents messages en vue de l'ajout de la traduction RS-RI <-> RC-RI
  • Rename du converter CISU pour les messages createCase
  • Ajout d'un converter par défaut pour les message RS-RI (sans implémentation des règles métier)
  • Ajout de caching pour les requêtes à l'API Github dans les tests

📄 Documentation

  • Track 3 : tuyauterie de la traduction RC<->RS

🔗 Ticket associé

Asana

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

There is no coverage information present for the Files changed

Total Project Coverage 62.11% 🍏

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Coverage

Converter - python code coverage
FileStmtsMissCoverMissing
constants.py40100% 
conversion_mixin.py23195%24
converter.py27292%35–36
utils.py146497%36, 51, 97, 109
cisu
   base_cisu_converter.py33390%7, 25, 31
   constants.py40100% 
   utils.py150100% 
cisu/create_case
   create_case_cisu_converter.py131496%119, 128, 231, 272
cisu/resources_info
   resources_info_cisu_constants.py80100% 
   resources_info_cisu_converter.py450100% 
conversion_strategy
   cisu_conversion_strategy.py37586%49, 71–72, 74, 77
   conversion_strategy.py60100% 
   health_conversion_strategy.py511374%54, 56, 58, 60, 62, 64, 66, 68, 70, 72, 74, 76, 78
versions
   base_message_converter.py731283%9, 65–67, 76, 87, 93, 97, 101, 105, 109, 115
   error_converter.py5180%7
   identical_message_converter.py150100% 
   utils.py53590%97–100, 106
versions/create_case_health
   create_case_health_converter.py182199%94
   create_case_health_update_converter.py50100% 
versions/create_case_health/v1_v2
   constants.py170100% 
versions/create_case_health/v2_v3
   constants.py290100% 
versions/document_link
   document_link_constants.py20100% 
   document_link_converter.py190100% 
versions/geo_positions_update
   geo_positions_update_constants.py40100% 
   geo_positions_update_converter.py49393%31, 42, 79
versions/geo_resources_details
   geo_resources_details_constants.py40100% 
   geo_resources_details_converter.py270100% 
versions/intervention_report
   intervention_report_constants.py130100% 
   intervention_report_converter.py730100% 
versions/reference
   reference_constants.py20100% 
   reference_converter.py130100% 
versions/resources_engagement
   resources_engagement_constants.py30100% 
   resources_engagement_converter.py220100% 
versions/resources_info
   resources_info_constants.py70100% 
   resources_info_converter.py900100% 
versions/resources_request
   resources_request_constants.py20100% 
   resources_request_converter.py210100% 
versions/resources_response
   resources_response_constants.py30100% 
   resources_response_converter.py160100% 
versions/resources_status
   resources_status_constants.py50100% 
   resources_status_converter.py460100% 
versions/rpis
   rpis_constants.py60100% 
   rpis_converter.py230100% 
TOTAL13595496% 

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

There is no coverage information present for the Files changed

Total Project Coverage 62.11% 🍏

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

There is no coverage information present for the Files changed

Total Project Coverage 62.11% 🍏

Comment on lines 48 to 49
return health_conversion_strategy(
rc_json_message, CISUConstants.MAINTAINED_CISU_VERSION, target_version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pour rompre le lien ici, au lieu de faire un if/else binaire dans conversion_strategy on ferait deux if successifs:

message = copy(edxl_json)
if is_cisu_conversion:
  message = cisu_conversion_strategy(message, ...)
if health_conversion_needed:
  message = health_conversion_strategy(message, ...)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(dépasse le cadre de cette PR)

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

There is no coverage information present for the Files changed

Total Project Coverage 62.11% 🍏

@SimonClo SimonClo changed the title Refactor/converter/cisu conversion pipeline feat(converter): RC-RI conversion Nov 13, 2025
@github-actions
Copy link

There is no coverage information present for the Files changed

Total Project Coverage 62.11% 🍏

@SimonClo SimonClo merged commit 6ca6f39 into main Nov 14, 2025
3 of 6 checks passed
@SimonClo SimonClo deleted the refactor/converter/cisu-conversion-pipeline branch November 14, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants