Skip to content

Conversation

@SimonClo
Copy link
Contributor

@SimonClo SimonClo commented Dec 2, 2025

🔎 Détails

Ajout de la version courante du converter dans ses logs

📄 Documentation

Ajoutez un (des) lien(s) vers la documentation si nécessaire

📸 Captures d'écran

Avant Après
Capture d’écran 2025-12-02 à 15 13 42

🔗 Ticket associé

Asana

@github-actions
Copy link

github-actions bot commented Dec 2, 2025

There is no coverage information present for the Files changed

Total Project Coverage 61.4% 🍏

@github-actions
Copy link

github-actions bot commented Dec 2, 2025

Coverage

Converter - python code coverage
FileStmtsMissCoverMissing
constants.py40100% 
conversion_mixin.py23195%24
converter.py45295%74–75
logging_config.py35197%29
utils.py149397%55, 101, 113
cisu
   base_cisu_converter.py33390%7, 25, 31
   constants.py40100% 
   identical_cisu_converter.py90100% 
   utils.py150100% 
cisu/create_case
   create_case_cisu_converter.py146497%127, 136, 244, 287
cisu/reference
   reference_converter.py9277%9, 13
cisu/resources_info
   resources_info_cisu_constants.py70100% 
   resources_info_cisu_converter.py520100% 
conversion_strategy
   cisu_conversion_strategy.py44197%60
   conversion_strategy.py60100% 
   health_conversion_strategy.py520100% 
versions
   base_message_converter.py811285%13, 74–76, 85, 96, 102, 106, 110, 114, 118, 124
   error_converter.py5180%7
   identical_message_converter.py150100% 
   utils.py27581%39–42, 48
versions/create_case_health
   constants.py40100% 
   create_case_health_converter.py1780100% 
   create_case_health_update_converter.py50100% 
versions/create_case_health/v1_v2
   constants.py170100% 
   utils.py440100% 
versions/create_case_health/v2_v3
   constants.py290100% 
versions/document_link
   document_link_constants.py20100% 
   document_link_converter.py190100% 
versions/geo_positions_update
   geo_positions_update_constants.py40100% 
   geo_positions_update_converter.py49393%31, 42, 79
versions/geo_resources_details
   geo_resources_details_constants.py40100% 
   geo_resources_details_converter.py270100% 
versions/intervention_report
   intervention_report_constants.py130100% 
   intervention_report_converter.py730100% 
versions/reference
   reference_constants.py20100% 
   reference_converter.py130100% 
versions/resources_engagement
   resources_engagement_constants.py30100% 
   resources_engagement_converter.py220100% 
versions/resources_info
   resources_info_constants.py70100% 
   resources_info_converter.py900100% 
versions/resources_request
   resources_request_constants.py20100% 
   resources_request_converter.py210100% 
versions/resources_response
   resources_response_constants.py30100% 
   resources_response_converter.py160100% 
versions/resources_status
   resources_status_constants.py50100% 
   resources_status_converter.py460100% 
versions/rpis
   rpis_constants.py60100% 
   rpis_converter.py230100% 
TOTAL14883897% 

Comment on lines 7 to 8
CONVERTER_VERSION = os.getenv("CONVERTER_VERSION", "0.0.0")

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

je comprends que "0.0.0" est un default.

Si on veut s'appuyer sur cette variable pour enrichir les logs dans une logique de contrôle d'intégrité, est-ce qu'on veut passer un default silencieusement ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bonne remarque, je retire la valeur par défaut

@SimonClo SimonClo force-pushed the chore/converter-log-version branch from c7b54be to 67c7ddd Compare December 2, 2025 14:13
@github-actions
Copy link

github-actions bot commented Dec 2, 2025

There is no coverage information present for the Files changed

Total Project Coverage 61.4% 🍏

@SimonClo SimonClo force-pushed the chore/converter-log-version branch from 67c7ddd to e571889 Compare December 2, 2025 14:16
@github-actions
Copy link

github-actions bot commented Dec 2, 2025

There is no coverage information present for the Files changed

Total Project Coverage 61.4% 🍏

@SimonClo SimonClo merged commit e41d3d8 into main Dec 3, 2025
2 checks passed
@SimonClo SimonClo deleted the chore/converter-log-version branch December 3, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants