-
Notifications
You must be signed in to change notification settings - Fork 0
chore(converter): add version in logs #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
| CONVERTER_VERSION = os.getenv("CONVERTER_VERSION", "0.0.0") | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
je comprends que "0.0.0" est un default.
Si on veut s'appuyer sur cette variable pour enrichir les logs dans une logique de contrôle d'intégrité, est-ce qu'on veut passer un default silencieusement ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bonne remarque, je retire la valeur par défaut
c7b54be to
67c7ddd
Compare
|
67c7ddd to
e571889
Compare
|
🔎 Détails
Ajout de la version courante du converter dans ses logs
📄 Documentation
📸 Captures d'écran
🔗 Ticket associé
Asana