Skip to content

validate: Add suppress_output option to jsonschema validator#374

Draft
lisongmin wants to merge 2 commits intoansible-collections:mainfrom
lisongmin:add-suppress_output-to-jsonschema-validate
Draft

validate: Add suppress_output option to jsonschema validator#374
lisongmin wants to merge 2 commits intoansible-collections:mainfrom
lisongmin:add-suppress_output-to-jsonschema-validate

Conversation

@lisongmin
Copy link
Copy Markdown

@lisongmin lisongmin commented Sep 15, 2024

SUMMARY

Add suppress_output option to jsonschema validator

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

validate

ADDITIONAL INFORMATION

When validate a json schema failed, the error block contains the source data and criteria.
And the data and criteria are usually too large, so we can't find the error message quickly.
Also the data may contains sensitive info that we don't want to show out.

This PR provides a way to suppress the data and criteria in the error block

@lisongmin lisongmin force-pushed the add-suppress_output-to-jsonschema-validate branch from 6ee10f6 to b4a0a01 Compare September 15, 2024 11:22
@softwarefactory-project-zuul
Copy link
Copy Markdown
Contributor

softwarefactory-project-zuul bot commented Sep 15, 2024

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/b260f34ab44146d98cdfc7be7d65e4e8

✔️ ansible-galaxy-importer SUCCESS in 3m 23s
✔️ build-ansible-collection SUCCESS in 5m 48s

@lisongmin lisongmin force-pushed the add-suppress_output-to-jsonschema-validate branch from 0448135 to d8f536a Compare September 15, 2024 12:04
@lisongmin lisongmin force-pushed the add-suppress_output-to-jsonschema-validate branch from 6b92fc6 to bf6425d Compare September 15, 2024 12:09
@lisongmin
Copy link
Copy Markdown
Author

lisongmin commented Sep 15, 2024

pre-commit.ci autofix

@softwarefactory-project-zuul
Copy link
Copy Markdown
Contributor

softwarefactory-project-zuul bot commented Sep 15, 2024

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/512e232a857f4844bbb01bc5d8819ac2

✔️ ansible-galaxy-importer SUCCESS in 4m 25s
✔️ build-ansible-collection SUCCESS in 6m 02s

@Ruchip16 Ruchip16 self-requested a review September 18, 2024 10:02
@Ruchip16
Copy link
Copy Markdown
Contributor

Ruchip16 commented Mar 21, 2025

@lisongmin thanks for raising this PR, just a small request could you kindly add changelog and integration tests to validate this following change?

@lisongmin
validate: Add suppress_output option to jsonschema validator
778faf6 
Signed-off-by: Songmin Li <lisongmin@protonmail.com>
@lisongmin lisongmin force-pushed the add-suppress_output-to-jsonschema-validate branch from ad02898 to 778faf6 Compare March 21, 2025 10:51
@softwarefactory-project-zuul
Copy link
Copy Markdown
Contributor

softwarefactory-project-zuul bot commented Mar 21, 2025

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/4f8ee353c80e42dda8f7fe8da5c6d487

✔️ ansible-galaxy-importer SUCCESS in 4m 04s
✔️ build-ansible-collection SUCCESS in 5m 19s

@lisongmin
Copy link
Copy Markdown
Author

lisongmin commented Mar 21, 2025

Done

@lisongmin thanks for raising this PR, just a small request could you kindly add changelog and integration tests to validate this following change?

Ruchip16
Ruchip16 reviewed Mar 24, 2025
View reviewed changes
@lisongmin @Ruchip16
fix typo in changelog
047ad95 
Co-authored-by: Ruchi Pakhle <72685035+Ruchip16@users.noreply.github.com>
@softwarefactory-project-zuul
Copy link
Copy Markdown
Contributor

softwarefactory-project-zuul bot commented Mar 24, 2025

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/db69abd6966a486fac3652b1bfaf76e6

✔️ ansible-galaxy-importer SUCCESS in 2m 54s
✔️ build-ansible-collection SUCCESS in 5m 19s

@Ruchip16 Ruchip16 added the enhancement New feature or request label Jun 9, 2025
@Ruchip16 Ruchip16 marked this pull request as draft June 9, 2025 17:42
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 18, 2025

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

1 more reviewer

@Ruchip16 Ruchip16 Ruchip16 left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lisongmin @Ruchip16