hashicorp.vault release process#58
hashicorp.vault release process#58mandar242 wants to merge 8 commits intoansible-collections:mainfrom
Conversation
0c60394 to
40cce8f
Compare
Releases/release_collections.md
Outdated
|
|
||
| * For a **minor release**, make sure the backport of the PRs from the `main` branch to the release branch is successful. For more information on backporting PRs, refer to [the backporting page](https://github.com/ansible-collections/cloud-content-handbook/blob/main/backport_changes.md) of the team handbook. | ||
|
|
||
| * Before starting the release preparation, pull the latest changes from `main` to `stable-X`: |
There was a problem hiding this comment.
This step can be skipped if we implement the backport process as it is for any other collection
There was a problem hiding this comment.
Maybe a note can be added saying this (in parenthesis and/or italics)?
There was a problem hiding this comment.
I'm not sure this step should be here. Depending on what the release is, we won't want to pull everything from main. I agree with @abikouo. Our backport process should make this step unnecessary, and in many cases it would be incorrect.
There was a problem hiding this comment.
@gravesm @abikouo Currently, for ansible-automation-platform, the workflow permissions are set at the enterprise level and we’re not able to modify them. David Schmidt suggested creating a GitHub token (ideally owned by a bot), granting it the required permissions, and having that bot handle the backporting work. As I understand it, we will need to continue doing backports manually until we set up the bot.
Please let me know if there are any other options.
There was a problem hiding this comment.
Yeah, we'll need to do backports manually for this repo, but we should be doing that as we go, not just pulling recent changes from main before doing a release. I still think we should remove this step.
There was a problem hiding this comment.
updated the note mentioning that it should be handled with backport-x label, but can also be done manually while backporting is not working, and it is important to make sure latest main changes are present in stable-x before release.
integrate hashicorp.vault release steps
32eb586 to
b04885e
Compare
| git pull upstream main | ||
| git push upstream stable-X | ||
| ``` | ||
|
|
There was a problem hiding this comment.
I’m not sure I understand this. It reads as repetitive. We cut the stable branch for a major release after code freeze, and the paragraph above already covers backports for minor releases.
Can you clarify whether you are trying to convey something specific to the Hashi collection here?
There was a problem hiding this comment.
updated to specify hashicorp.vault specifically where needed
|
|
||
| * **Once the [CI for the release](https://ansible.softwarefactory-project.io/zuul/status) passes** (standard collections), inform the Partner Engineering team on the `#ansible-partners` Slack channel about the release. For supported content collections (e.g., `amazon.aws`), this includes requesting approval for Automation Hub. | ||
|
|
||
| > ** HashiCorp Vault Collection (`hashicorp.vault`)**: Skip the Zuul CI step - the GitHub Actions workflow handles publishing automatically. After the workflow completes successfully, inform the Partner Engineering team on the `#ansible-partners` channel about the release. |
There was a problem hiding this comment.
| > ** HashiCorp Vault Collection (`hashicorp.vault`)**: Skip the Zuul CI step - the GitHub Actions workflow handles publishing automatically. After the workflow completes successfully, inform the Partner Engineering team on the `#ansible-partners` channel about the release. | |
| > **HashiCorp Vault Collection (`hashicorp.vault`)**: Skip the Zuul CI step - the GitHub Actions workflow handles publishing automatically. After the workflow completes successfully, inform the Partner Engineering team on the `#ansible-partners` channel about the release. |
SUMMARY
Add release process of hashicorp.vault
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION