Skip to content

[PR #10007/373334d6 backport][stable-10] Add xdg_mime module#10072

Merged
felixfontein merged 1 commit intostable-10from
patchback/backports/stable-10/373334d6684139dbf2ce5aca1de2cce019a816e0/pr-10007
Apr 26, 2025
Merged

[PR #10007/373334d6 backport][stable-10] Add xdg_mime module#10072
felixfontein merged 1 commit intostable-10from
patchback/backports/stable-10/373334d6684139dbf2ce5aca1de2cce019a816e0/pr-10007

Conversation

@patchback
Copy link

@patchback patchback bot commented Apr 26, 2025

This is a backport of PR #10007 as merged into main (373334d).

SUMMARY

Adds a new module called xdg_mime. It's based on gio_mime module, but it uses xdg-mime instead of gio to do the configuration.
My first idea was to create a more generic module called mime, but @russoz suggested creating a separated module. Maybe the could merge in the future.

ISSUE TYPE
  • New Module/Plugin Pull Request
COMPONENT NAME

xdg_mime

ADDITIONAL INFORMATION

* Add version of xdg_mime module

* Fix xdg_mime_get since the command is different

* Add query parameter

* Fix order of parameters

* Add myself to BOTMETA

* Add unit tests

* Fix the way we deal when there is no handler set

* Improve documentation

* Remove unused import

* Fix documentation

* Strip xdg-mime from version string

* Fix information about version

* Add error message sample

* Add test to invalid handler

* Add support to multiple mime-types

* Change the output parameter from handlers to handler

* Change tests related to multiple mime-type support

* Small fixes

* Stop using constant to enable changed state

* Add before_handlers and after_handlers

* Change tests to use before and after structures

* Add a stronger message about using a non-installed handler

* Manage some edge cases

* Change error message to match the new value

* Add some fixes

* Change some tests

* Update plugins/modules/xdg_mime.py

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

* Remove a blank line

* Remove single quote

* Add xdg-mime to the version in the mocks

* Remove after_handlers and make code simpler

* Update tests to work without after_handlers

* Remove diff_params and clean output_params

* Make mime_type plural since it supports multiple items

* Move the handler check to module init

* Use anchors in the test to make yaml simpler

* Update plugins/modules/xdg_mime.py

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

* Update plugins/modules/xdg_mime.py

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

* Update plugins/modules/xdg_mime.py

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

* Update plugins/modules/xdg_mime.py

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

* Update plugins/modules/xdg_mime.py

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

* Update plugins/modules/xdg_mime.py

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

* Update plugins/modules/xdg_mime.py

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

* Update plugins/modules/xdg_mime.py

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

* Update plugins/modules/xdg_mime.py

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

* Update plugins/modules/xdg_mime.py

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

* Add blank line to separe examples

* Update plugins/modules/xdg_mime.py

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

* Add a small homage to my late grandma

* Update plugins/modules/xdg_mime.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Fix pep8 problem with the homage

* Remove trailing whitespace

* Update plugins/modules/xdg_mime.py

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

---------

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 373334d)
@patchback patchback bot mentioned this pull request Apr 26, 2025
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added backport module module module_utils module_utils new_contributor Help guide this first time contributor plugins plugin (any type) tests tests unit tests/unit labels Apr 26, 2025
@felixfontein felixfontein merged commit 28fb1e3 into stable-10 Apr 26, 2025
135 checks passed
@felixfontein felixfontein deleted the patchback/backports/stable-10/373334d6684139dbf2ce5aca1de2cce019a816e0/pr-10007 branch April 26, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport module_utils module_utils module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests unit tests/unit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants