nfs_exports_info: new module #10122
Open
nfs_exports_info: new module #10122
+260
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
module
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
the
needs_revision
This comment was marked as outdated.
This comment was marked as outdated.
felixfontein
added
check-before-release
added 2 commits
May 13, 2025 07:33
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
the
needs_ci
ansibullbot
removed
the
needs_ci
ansibullbot
removed
ci_verified
felixfontein
added
the
backport-11
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
ci_verified
ansibullbot
removed
ci_verified
added 2 commits
June 17, 2025 08:52
|
@yousefenzhad This PR was evaluated as a potentially problematic PR for the following reasons:
Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: |
ansibullbot
added
needs_rebase
Comment on lines
+48
to
+53
| exports_info: | ||
| description: | ||
| - A mapping of shared folders to IPs and their options, or the reverse. | ||
| - What it is depends on O(output_format). | ||
| type: dict | ||
| returned: always |
There was a problem hiding this comment.
@yousefenzhad this is still open, and something that really should be changed. Using the same name for two very different things is a bad idea and prevents this to be documented correctly.
plugins/modules/nfs_exports_info.py
Outdated
Comment on lines
60
to
61
| - A dictionary containing various hash values of the /etc/exports file for integrity verification. | ||
| - Keys are the hash algorithm names (e.g., 'sha256', 'sha1', 'md5'), and values are their corresponding hexadecimal digests. |
There was a problem hiding this comment.
Suggested change
| - A dictionary containing various hash values of the /etc/exports file for integrity verification. | |
| - Keys are the hash algorithm names (e.g., 'sha256', 'sha1', 'md5'), and values are their corresponding hexadecimal digests. | |
| - A dictionary containing various hash values of the C(/etc/exports) file for integrity verification. | |
| - Keys are the hash algorithm names (for example C(sha256), C(sha1), C(md5)), and values are their corresponding hexadecimal digests. |
There was a problem hiding this comment.
Good catch! I've made the change and pushed it.
|
Also could you please squash some of the commits to reduce the number of commits? |
|
Ping @yousefenzhad needs_info |
ansibullbot
added
the
needs_info
|
@yousefenzhad This pullrequest is waiting for your response. Please respond or the pullrequest will be closed. |
|
Thanks for the heads-up. I'm currently working on addressing the feedback and will push the changes soon." |
ansibullbot
removed
the
needs_info
Yes I do it. |
felixfontein
removed
the
backport-11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This pull request introduces a new Ansible module that parses the
/etc/exportsfileto extract NFS shared folder information, including export paths and associated options.
This is useful for automation tasks that require visibility into NFS export configurations.
ISSUE TYPE
COMPONENT NAME
nfs_exports_info
ADDITIONAL INFORMATION
This module reads and parses the
/etc/exportsfile line by line, ignoring comments and blank lines,and returns a structured list of dictionaries with the following information for each export: