Skip to content

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Remove announced features and apply announced breaking changes for 12.0.0.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

various

@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added callback callback plugin docs_fragments docs_fragments plugin (shared docs) feature This issue/PR relates to a feature request integration tests/integration module module module_utils module_utils plugins plugin (any type) tests tests unit tests/unit labels Oct 6, 2025
@felixfontein
Copy link
Collaborator Author

One thing that's missing here and will come in a follow-up is removing support for ansible-core 2.16. (That will also involve moving ansible-core 2.17 into the EOL CI.)

@felixfontein felixfontein requested a review from russoz October 6, 2025 20:55
Copy link
Collaborator

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @felixfontein

One fix and a possible adjustment. Thanks for putting it all together.

Comment on lines +147 to +148
- Note that V(auto) will be deprecated in a future version.
# TODO: Deprecate 'auto' in community.general 13.0.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not

Suggested change
- Note that V(auto) will be deprecated in a future version.
# TODO: Deprecate 'auto' in community.general 13.0.0
- Note that V(auto) will be deprecated in community.general 13.0.0.
# TODO: Deprecate 'auto' in community.general 13.0.0

?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd keep this open until we decide (by merging an appropriate PR) to actually deprecate it. We might forget to merge a PR that goes into 13.0.0 :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okie, makes sense

Co-authored-by: Alexei Znamensky <[email protected]>
@felixfontein felixfontein added the breaking_change This PR contains a breaking change that MUST NOT be backported label Oct 7, 2025
@felixfontein felixfontein requested a review from russoz October 8, 2025 18:11
Copy link
Collaborator

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixfontein felixfontein merged commit 0b72737 into ansible-collections:main Oct 9, 2025
137 checks passed
@felixfontein felixfontein deleted the v12 branch October 9, 2025 11:50
@felixfontein
Copy link
Collaborator Author

@russoz thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking_change This PR contains a breaking change that MUST NOT be backported callback callback plugin docs_fragments docs_fragments plugin (shared docs) feature This issue/PR relates to a feature request integration tests/integration module_utils module_utils module module plugins plugin (any type) shipit tests tests unit tests/unit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants