Skip to content

Conversation

@saibug
Copy link

@saibug saibug commented Nov 12, 2025

SUMMARY

This PR will update the module to be idempotent by:

  • Checking the current connection status before executing commands.
  • Avoiding unnecessary commands when the desired state has already been achieved.
  • Returning changed=False when no action is required.
  • Properly managing check mode for up and down states.
  • The module will no longer generate changes when an interface is already in the desired state, so that respect Ansible's idempotence principle.

Ref : #9897

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • nmcli

@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type) labels Nov 12, 2025
@ansibullbot

This comment was marked as outdated.

@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Nov 12, 2025
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-12 Automatically create a backport for the stable-12 branch labels Nov 12, 2025
@ansibullbot ansibullbot removed the ci_verified Push fixes to PR branch to re-run CI label Nov 12, 2025
@ansibullbot

This comment was marked as outdated.

@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI and removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Nov 12, 2025
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Nov 20, 2025
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Could you please add a changelog fragment? Thanks.

Also having tests for this would be helpful.

@saibug
Copy link
Author

saibug commented Nov 21, 2025

Thanks for your contribution! Could you please add a changelog fragment? Thanks.

Also having tests for this would be helpful.

@felixfontein thanks for replying..
OK I would update PR with your observations.

@ansibullbot ansibullbot removed the stale_ci CI is older than 7 days, rerun before merging label Nov 21, 2025
@ansibullbot

This comment was marked as outdated.

@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Nov 21, 2025
@ansibullbot ansibullbot removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Nov 21, 2025
@saibug saibug requested a review from felixfontein November 22, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-12 Automatically create a backport for the stable-12 branch check-before-release PR will be looked at again shortly before release and merged if possible. feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants