Skip to content

Stop re-defining the argument spec in unit tests #11235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Stop re-defining the argument spec in unit tests #11235

wants to merge 2 commits into from
+35 −274

Conversation

@felixfontein
Copy link
Collaborator

@felixfontein felixfontein commented Nov 30, 2025

SUMMARY

DRY.

Ref: #11182 (comment)

ISSUE TYPE
  • Bugfix Pull Request
  • Test Pull Request
COMPONENT NAME

archive unit tests
java_keystore unit tests
nmlci unit tests

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-11 Automatically create a backport for the stable-10 branch backport-12 Automatically create a backport for the stable-12 branch labels Nov 30, 2025
@ansibullbot
Copy link
Collaborator

ansibullbot commented Nov 30, 2025

cc @Mogztter @alcamie101 @bendoh @quidame
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module module plugins plugin (any type) tests tests unit tests/unit labels Nov 30, 2025
@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Nov 30, 2025
@ansibullbot ansibullbot removed the ci_verified Push fixes to PR branch to re-run CI label Nov 30, 2025
@felixfontein felixfontein requested a review from russoz November 30, 2025 14:33
@ansibullbot ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Nov 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@russoz russoz Awaiting requested review from russoz

Assignees

No one assigned

Labels

backport-11 Automatically create a backport for the stable-10 branch backport-12 Automatically create a backport for the stable-12 branch bug This issue/PR relates to a bug check-before-release PR will be looked at again shortly before release and merged if possible. module module plugins plugin (any type) tests tests unit tests/unit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@felixfontein @ansibullbot