Skip to content

kopia: Add kopia_repository module#11752

Draft
munchtoast wants to merge 3 commits intoansible-collections:mainfrom
munchtoast:add-kopia-module-repository
Draft

kopia: Add kopia_repository module#11752
munchtoast wants to merge 3 commits intoansible-collections:mainfrom
munchtoast:add-kopia-module-repository

Conversation

@munchtoast
Copy link
Copy Markdown
Contributor

@munchtoast munchtoast commented Apr 8, 2026

SUMMARY
ISSUE TYPE
  • New Module/Plugin Pull Request
COMPONENT NAME

kopia
kopia_repository

ADDITIONAL INFORMATION

@munchtoast munchtoast changed the title Add kopia module repository kopia: Add kopia_repository module Apr 8, 2026
@ansibullbot ansibullbot added WIP Work in progress module module module_utils module_utils new_plugin New plugin plugins plugin (any type) tests tests unit tests/unit labels Apr 8, 2026
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-12 Automatically create a backport for the stable-12 branch labels Apr 8, 2026
Copy link
Copy Markdown
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I've added some first comments.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename this to _kopia.py.

# Copyright (c) 2026, Dexter Le <dextersydney2001@gmail.com>
# GNU General Public License v3.0+ (see LICENSES/GPL-3.0-or-later.txt or https://www.gnu.org/licenses/gpl-3.0.txt)
# SPDX-License-Identifier: GPL-3.0-or-later

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Note that this module util is **PRIVATE** to the collection. It can have breaking changes at any time.
# Do not use this from other collections or standalone plugins/modules!

- Repository password used to encrypt and decrypt repository contents.
- Required if O(state=created) or O(state=connected).
type: str
fingerprint_ssl:
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use TLS instead of SSL. The protocol hasn't been called SSL for decades now :)

Suggested change
fingerprint_ssl:
fingerprint_tls:

fingerprint_ssl=dict(type="str"),
url=dict(type="str"),
throttle_operation=dict(type="str", default="get", choices=["set", "get"]),
backend=dict(
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should't backend also come from KOPIA_COMMON_ARGUMENT_SPEC?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-12 Automatically create a backport for the stable-12 branch check-before-release PR will be looked at again shortly before release and merged if possible. module_utils module_utils module module new_plugin New plugin plugins plugin (any type) tests tests unit tests/unit WIP Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants