generated from ansible-collections/collection_template
-
Notifications
You must be signed in to change notification settings - Fork 39
proxmox_zone - new module #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Thulium-Drake
merged 19 commits into
ansible-collections:main
from
JanaHoch:feature/zones
Sep 17, 2025
Merged
Changes from 14 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
d76ddee
proxmox_zone: new module for proxmox_zones
JanaHoch d8ac153
proxmox_zone: Create new zone
JanaHoch dee432f
proxmox_zone: Keep common parameter for all conditions
JanaHoch 2e27f61
proxmox_zone: Implement locking
JanaHoch fa60bb4
proxmox_zone: Added update_zone()
JanaHoch de14226
proxmox_zone: added zone_absent()
JanaHoch 57c7e7d
proxmox_zone: Added document and examples
JanaHoch 3f82ab6
proxmox_zone: add missing exception handling for zone_preent()
JanaHoch 70d3d83
proxmox_zone: validate params
JanaHoch 0c0bb74
proxmox_zone and proxmox module_utils
JanaHoch a5773bf
proxmox_zone: Fix sanity issues
JanaHoch e69c8d9
proxmox_zone: fix minor issues found during testing
JanaHoch 8e549c3
proxmox_zone: Add unit tests
JanaHoch 7b24750
proxmox_zone: Add missing boolean conversion
JanaHoch 4693b66
module_utils: Create new base class ProxmoxSdnAnsible()
JanaHoch cf1f4c2
Create seprate proxmox_zone_info
JanaHoch 5741796
proxmox_zone: Merge statepresent and update
JanaHoch 0cf6a3b
proxmox_zone: Get lock just before making changes
JanaHoch 5fef669
Update unit tests for proxmox_zone & proxmox_zone_info
JanaHoch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,3 +35,4 @@ action_groups: | |
- proxmox_user | ||
- proxmox_user_info | ||
- proxmox_vm_info | ||
- proxmox_zone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Thulium-Drake The last time i contributed to community.general f-strings were not allowed due to backwards compatibility. But sanity-tests pass on this code. Do you know why? Has python2 compatibility been deprecated for this collection?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In README python 3.7 is mentioned so I thought it should be ok. If not let me know i can update but python2 deprecated when the only python I knew was a snake... :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah i see, very nice.
So we could use type hints, as well now, @Thulium-Drake ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ehm, good question, @felixfontein what are the guidelines in
community.general
for this?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whether Python 2 compatibility is still needed depends on a) the supported ansible-core versions of the collection, and b) on the collection itself as well (there might be further restrictions on target version numbers).
For community.general, we usually support all ansible-core versions that are not EOL and haven't been EOL for more than a few weeks at the time of a new major release. That means that community.general 11.0.0 (released in spring) still supports ansible-core 2.16, which still supports Python 2.7 on the target. But the next major release, community.general 12.0.0 (should be released in November), will only support ansible-core >= 2.17, and thus will be Python 3.7+.
(I'm not saying this policy is great, but at least it is predictable and doesn't let the CI matrix explode... like community.crypto 2.x.y, which supports everything from Ansible 2.9 up to ansible-core 2.19, or community.internal_test_tools and community.library_inventory_filtering_v1, which even cover Ansible 2.9 up to ansible-core devel :) )
community.proxmox 1.0.0 said it only supports ansible-core 2.17+ from the beginning, so it was always Python 3.7+.