Support all option with rabbitmq_feature_flag#170
Open
jovial wants to merge 1 commit intoansible-collections:mainfrom
Open
Support all option with rabbitmq_feature_flag#170jovial wants to merge 1 commit intoansible-collections:mainfrom
jovial wants to merge 1 commit intoansible-collections:mainfrom
Conversation
This is useful to enable all feature flags before an upgrade, see: - https://www.rabbitmq.com/docs/upgrade#enable-required-feature-flags-before-attempting-the-upgrade - https://www.rabbitmq.com/docs/feature-flags#how-to-enable-feature-flags Fixes: ansible-collections#169
|
/rebuild |
|
@cognifloyd @odyssey4me @jgkirschbaum @Im0 |
cognifloyd
reviewed
Jun 11, 2024
| def _exec(self, args, force_exec_in_check_mode=False): | ||
| if not self.module.check_mode or (self.module.check_mode and force_exec_in_check_mode): | ||
| cmd = [self._rabbitmqctl, '-q', '-n', self.node] | ||
| cmd = [self._rabbitmqctl, '--formatter', 'json', '-q', '-n', self.node] |
Collaborator
There was a problem hiding this comment.
Does using this restrict which versions of rabbitmq we support?
Collaborator
There was a problem hiding this comment.
@jovial do you have any thoughts about the about the above?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
This is useful to enable all feature flags before an upgrade, see:
I switched to using the json output instead of attempting to parse the tabbed output for simplicity. I also
needed to include the stability field as 'all' only enables stable features. This was needed to correctly
set the changed field.
Fixes: #169
ISSUE TYPE
COMPONENT NAME
rabbitmq_feature_flag
ADDITIONAL INFORMATION