Skip to content

fix: RabbitMQ user module API response success conditions to include 201 and 204 #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vajeen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: RabbitMQ user module API response success conditions to include 201 and 204 #219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions plugins/modules/rabbitmq_user.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,7 +586,7 @@ def add(self):
data = {"password": self.password, "tags": self.treat_tags_for_api() or ""}
response = self.request_users_api('PUT', data)

if not response.ok or (response.status_code == 204):
if response.status_code not in (201, 204):
msg = ("Error trying to create user %s in rabbitmq. "
"Status code '%s'.") % (self.username, response.status_code)
self.module.fail_json(msg=msg)
Expand All @@ -607,19 +607,13 @@ def delete(self):

def change_password(self):
if self.login_host is not None:
data = {"password": self.password or "", "tags": self.tags or ""}
data = {"password": self.password or "", "tags": self.treat_tags_for_api() or ""}
response = self.request_users_api('PUT', data)

if not response.ok or (response.status_code == 204):
msg = ("Error trying to set tags for the user %s in rabbitmq. "
if response.status_code not in (201, 204):
msg = ("Error trying to change password for the user %s in rabbitmq. "
"Status code '%s'.") % (self.username, response.status_code)
self.module.fail_json(msg=msg)
else:
self.module.fail_json(
msg="Error setting tags for the user",
status=response.status_code,
details=response.text
)
else:
if self.password:
self._exec(['change_password', self.username, self.password])
Expand All @@ -631,7 +625,7 @@ def set_tags(self):
data = {"password": self.password, "tags": self.treat_tags_for_api() or ""}
response = self.request_users_api('PUT', data)

if not response.status_code == 204:
if response.status_code not in (201, 204):
msg = ("Error trying to set tags for the user %s in rabbitmq. "
"Status code '%s'.") % (self.username, response.status_code)
self.module.fail_json(msg=msg)
Expand Down
Loading