-
Notifications
You must be signed in to change notification settings - Fork 61
Partially fixed issue 363: Add missing parameters for path interface bridge and interface bridge port #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #423 +/- ##
=======================================
Coverage 85.85% 85.85%
=======================================
Files 30 30
Lines 4094 4094
Branches 1003 1003
=======================================
Hits 3515 3515
Misses 405 405
Partials 174 174 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @felixfontein, I am not currently working with older versions of RouterOS (nor am I familiar with them), |
changelogs/fragments/423_add_missing_parameters_for_interface_bridge.yml
Outdated
Show resolved
Hide resolved
That's a very good question, and something I've been wondering about as well. The RouterOS documentation is really bad about such things... I wish there would be some (automatically generated / machine readable) API docs that could be used as a basis for the API modules in this collection, but there don't seem to be any. Simply adding the new fields with the "current" minor version - as you did in this PR - sounds like a good idea; if someone is using an older version and notices that something is different there, they can create a bugfix to fix the version numbers. If nobody is using them, well, then it doesn't matter anyway :) |
…bridge.yml Co-authored-by: Felix Fontein <[email protected]>
|
@FelixRicke thanks for improving the modules! |
SUMMARY
Add missing parameters to path interface bridge and interface bridge port
Partially fixes issue #363.
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION