-
Notifications
You must be signed in to change notification settings - Fork 84
Add copp_traps to CoPP module as part of FBS feature #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proposed code changes and corresponding test results look good.
I am posting some minor change requests, mostly for "module" file documentation lines, but also a name change for one of the new options.
Thank you for adding Ansible support for the CoPP traps configuration and doing some helpful code cleanup for the modified files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing the review comments.
All current proposed changes and corresponding test results look good.
Approved.
SUMMARY
I added copp_traps to CoPP module as part of the FBS feature.
Please see model PR.
ISSUE TYPE
COMPONENT NAME
sonic_copp
OUTPUT
regression-2025-06-04-16-32-49.html.pdf
Checklist: