Skip to content

Conversation

stalabi1
Copy link
Collaborator

@stalabi1 stalabi1 commented Oct 7, 2024

SUMMARY

I added copp_traps to CoPP module as part of the FBS feature.
Please see model PR.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

sonic_copp

OUTPUT

regression-2025-06-04-16-32-49.html.pdf

Checklist:
  • I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.
  • I have provided a summary for this PR in valid "fragment" file format in the "changelogs/fragments" directory of this repository branch. Reference : Ansible Change Log Document

@stalabi1 stalabi1 requested a review from kerry-meyer as a code owner October 7, 2024 23:18
@stalabi1 stalabi1 added the enhancement New feature or request label Oct 7, 2024
@stalabi1 stalabi1 added this to the v3.1.0 milestone Oct 7, 2024
@stalabi1 stalabi1 changed the title Add copp_traps to CoPP module as a part of FBS feature Add copp_traps to CoPP module as part of FBS feature Oct 7, 2024
@stalabi1 stalabi1 requested a review from awhaley-dell January 24, 2025 21:52
Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed code changes and corresponding test results look good.

I am posting some minor change requests, mostly for "module" file documentation lines, but also a name change for one of the new options.

Thank you for adding Ansible support for the CoPP traps configuration and doing some helpful code cleanup for the modified files.

Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing the review comments.

All current proposed changes and corresponding test results look good.

Approved.

@kerry-meyer kerry-meyer merged commit 4587401 into ansible-collections:main Jun 5, 2025
16 checks passed
@stalabi1 stalabi1 deleted the copp branch September 10, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants