Add Dell Enterprise SONiC 'ip_neighbor_interfaces' module#499
Merged
kerry-meyer merged 8 commits intoansible-collections:mainfrom Sep 19, 2025
Merged
Conversation
stalabi1
requested changes
Jul 24, 2025
plugins/module_utils/network/sonic/argspec/ip_neighbor_interfaces/ip_neighbor_interfaces.py
Outdated
Show resolved
Hide resolved
plugins/module_utils/network/sonic/config/ip_neighbor_interfaces/ip_neighbor_interfaces.py
Outdated
Show resolved
Hide resolved
tests/regression/roles/sonic_ip_neighbor_interfaces/tasks/cleanup_tests.yaml
Outdated
Show resolved
Hide resolved
tests/regression/roles/sonic_ip_neighbor_interfaces/tasks/preparation_tests.yaml
Outdated
Show resolved
Hide resolved
stalabi1
approved these changes
Sep 11, 2025
Collaborator
stalabi1
left a comment
There was a problem hiding this comment.
Kerry has merged fixes for the 2 sanity errors so you can synch your branch.
kerry-meyer
reviewed
Sep 17, 2025
plugins/module_utils/network/sonic/config/ip_neighbor_interfaces/ip_neighbor_interfaces.py
Show resolved
Hide resolved
kerry-meyer
reviewed
Sep 17, 2025
plugins/module_utils/network/sonic/config/ip_neighbor_interfaces/ip_neighbor_interfaces.py
Show resolved
Hide resolved
kerry-meyer
reviewed
Sep 17, 2025
Collaborator
There was a problem hiding this comment.
The proposed code changes look great. The structure is clean and efficient. The posted test results are all good.
I am posting a couple of comments. They are just questions, but at least one of them may require a minor change (in "merge" handling).
kerry-meyer
approved these changes
Sep 19, 2025
Collaborator
kerry-meyer
left a comment
There was a problem hiding this comment.
Thank you for making the incremental changes to address the issue regarding presence of the 'mac' option when creating a new IP neighbor.
All current proposed code changes and corresponding test results look good.
Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Model PR: ansible-network/resource_module_models#292
GitHub Issues
List the GitHub issues impacted by this PR. If no Github issues are affected, please indicate this with "N/A".
ISSUE TYPE
COMPONENT NAME
sonic_ip_neighbor_interfaces
OUTPUT
ADDITIONAL INFORMATION
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Regression report: ip_neighbor_interfaces_regression-2025-09-18-11-56-49.zip