Added option to create unformatted volumes in ibm_svc_manage_volume.py #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #34
I submitted an issue with this. This adds a new parameter to ibm_svc_manage_volume with "format_disk". Leaving it out or setting it to true will not change things. Setting it to false will create unformatted volumes by using mkvdisk instead of mkvolume
ISSUE TYPE
COMPONENT NAME
ibm_svc_manage_volume
ADDITIONAL INFORMATION
The problem is that addvolume assumes that the user wants to format volumes. When standing up a new, large environment, this can suck up lots of resources and take an extremely long period of time. As a result it's important to make it an option to create unformatted volumes.