Add Developer guide and Architecture document#189
Conversation
andrewhughes101
force-pushed
the
skills-share
branch
from
3e1b73f to
df1b817
Compare
AndrewTwydell
left a comment
AndrewTwydell
left a comment
There was a problem hiding this comment.
Yep looks great, couple related questions nice looking fine 👍🏼
andrewhughes101
force-pushed
the
skills-share
branch
from
df1b817 to
d5a67bb
Compare
| - [`cmci.py`](plugins/module_utils/cmci.py) - Base class for all CMCI modules | ||
| - Handles HTTP communication with CMCI REST API | ||
| - Manages authentication (basic and certificate) | ||
| - Parses XML responses using xmltodict |
There was a problem hiding this comment.
I think xmltodict has been removed now so we can remove this or update it to mention using Python libs
There was a problem hiding this comment.
Thats in this PR, not merged yet #190
It also has the change to remove this line
There was a problem hiding this comment.
Ah I see, I did a quick check in the code base and thought it had been removed already!
DEVELOPER_GUIDE.md
Outdated
| **VS Code Extensions:** | ||
| - Red Hat Ansible extension | ||
| - Python extension | ||
| - GitLens for Git integration |
There was a problem hiding this comment.
Should this be removed?
There was a problem hiding this comment.
Oh good find, so its also still in the devcontainer json, hence why its here, I'll remove it from both
There was a problem hiding this comment.
Fixed and re-pushed
andrewhughes101
force-pushed
the
skills-share
branch
from
d5a67bb to
da47359
Compare
3 participants
Adds new developer guide with commands and reference for how to develop this collection
Adds a new Architecture document explaining how this collection is organised and works