[1.5.0-beta.1] [Bug] [zos_copy] Accented characters break is_empty (#634)

* Changed is_empty for sequential datasets

* Added changelog fragment

* Added test case for dataset with accented chars

---------

Co-authored-by: ddimatos <[email protected]>

Author: rexemin

changelogs/fragments/600-zos_copy-special-characters.yml

@@ -0,0 +1,4 @@
+bugfixes:
+ - zos_copy - fixes a bug where if a destination has accented characters in
+   its content, the module would fail when trying to determine if it is empty.
+   (https://github.com/ansible-collections/ibm_zos_core/pull/634)

plugins/module_utils/data_set.py

@@ -655,7 +655,9 @@ def is_empty(name, volume=None):
         if ds_type in DataSet.MVS_PARTITIONED:
             return DataSet._pds_empty(name)
         elif ds_type in DataSet.MVS_SEQ:
-            return len(datasets.read(name, tail=10)) == 0
+            module = AnsibleModuleHelper(argument_spec={})
+            rc, stdout, stderr = module.run_command("head \"//'{0}'\"".format(name))
+            return rc == 0 and len(stdout.strip()) == 0
         elif ds_type in DataSet.MVS_VSAM:
             return DataSet._vsam_empty(name)
 

tests/functional/modules/test_zos_copy_func.py

@@ -32,6 +32,15 @@
 DUMMY DATA ---- LINE 007 ------
 """
 
+DUMMY_DATA_SPECIAL_CHARS = """DUMMY DATA ---- LINE 001 ------
+DUMMY DATA ---- LINE ÁÁÁ------
+DUMMY DATA ---- LINE ÈÈÈ ------
+DUMMY DATA ---- LINE 004 ------
+DUMMY DATA ---- LINE 005 ------
+DUMMY DATA ---- LINE 006 ------
+DUMMY DATA ---- LINE 007 ------
+"""
+
 VSAM_RECORDS = """00000001A record
 00000002A record
 00000003A record
@@ -1167,6 +1176,37 @@ def test_copy_ps_to_non_empty_ps(ansible_zos_module, force):
         hosts.all.zos_data_set(name=dest, state="absent")
 
 
+@pytest.mark.seq
+@pytest.mark.parametrize("force", [False, True])
+def test_copy_ps_to_non_empty_ps_with_special_chars(ansible_zos_module, force):
+    hosts = ansible_zos_module
+    src_ds = TEST_PS
+    dest = "USER.TEST.SEQ.FUNCTEST"
+
+    try:
+        hosts.all.zos_data_set(name=dest, type="seq", state="absent")
+        hosts.all.zos_copy(content=DUMMY_DATA_SPECIAL_CHARS, dest=dest)
+
+        copy_res = hosts.all.zos_copy(src=src_ds, dest=dest, remote_src=True, force=force)
+        verify_copy = hosts.all.shell(
+            cmd="cat \"//'{0}'\"".format(dest), executable=SHELL_EXECUTABLE
+        )
+
+        for result in copy_res.contacted.values():
+            if force:
+                assert result.get("msg") is None
+                assert result.get("changed") is True
+                assert result.get("dest") == dest
+            else:
+                assert result.get("msg") is not None
+                assert result.get("changed") is False
+        for result in verify_copy.contacted.values():
+            assert result.get("rc") == 0
+            assert result.get("stdout") != ""
+    finally:
+        hosts.all.zos_data_set(name=dest, state="absent")
+
+
 @pytest.mark.seq
 @pytest.mark.parametrize("backup", [None, "USER.TEST.SEQ.FUNCTEST.BACK"])
 def test_backup_sequential_data_set(ansible_zos_module, backup):