Skip to content

[Enabler][zos_operator] Update module interface #2230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Aug 12, 2025

Conversation

AndreMarcel99
Copy link
Collaborator

SUMMARY

Update module zos_operator interface.
Fixes #2158

ISSUE TYPE
  • Enabler Pull Request
COMPONENT NAME

Add unit_time option for select centiseconds and seconds also as return value.

ADDITIONAL INFORMATION
Screenshot 2025-08-07 at 7 32 53 a m Screenshot 2025-08-07 at 7 32 35 a m Screenshot 2025-08-07 at 7 33 14 a m

@AndreMarcel99 AndreMarcel99 marked this pull request as ready for review August 7, 2025 13:38
rexemin
rexemin previously requested changes Aug 7, 2025
end = timer()
rc = response.rc
stdout = response.stdout_response
stderr = response.stderr_response
elapsed = round(end - start, 2)
if time_unit != "s":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could just check if time_unit is cs

@fernandofloresg fernandofloresg changed the title Enabler/2158/update zos operator interface [Enabler][zos_operator] Update module interface Aug 7, 2025
Copy link
Collaborator

@fernandofloresg fernandofloresg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggested changes by Ale seem appropriate, apart from that all looks good from my end.

@fernandofloresg fernandofloresg dismissed rexemin’s stale review August 12, 2025 17:45

Alex is out on vacations and Marcel has fixed their comments.

@fernandofloresg fernandofloresg merged commit f9e9e65 into dev Aug 12, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Update zos_operator module interface
4 participants