-
Notifications
You must be signed in to change notification settings - Fork 43
[Enabler][2142]update_zos_copy_interface #2232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see some confusion/mixing of 'force' versus 'replace'. Int the comments, it looks like replace is gone, but in the code, it is still there. Can you clarify this?
@@ -0,0 +1,4 @@ | |||
breaking_changes: | |||
- zos_copy - Option ``force_lock`` is deprecated in favor of ``force``. Option ``force`` is deprecated in favor of ``replace``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a little awkward: force_lock->force->replace seems confusing. Why not reword as (force_lock and force are deprecated in favor of replace).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, left a minor comment of a typo fix. thanks for adding the new checks in the test assertions.
Co-authored-by: Fernando Flores <[email protected]>
SUMMARY
Update zos_copy interface
Fixes #2142
ISSUE TYPE
ADDITIONAL INFORMATION