Skip to content

[Enabler][2142]update_zos_copy_interface #2232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Aug 11, 2025

Conversation

AndreMarcel99
Copy link
Collaborator

@AndreMarcel99 AndreMarcel99 commented Aug 7, 2025

SUMMARY

Update zos_copy interface

Fixes #2142

ISSUE TYPE
  • Enabler Pull Request
ADDITIONAL INFORMATION
Screenshot 2025-08-08 at 3 42 05 p m Screenshot 2025-08-08 at 3 42 51 p m Screenshot 2025-08-08 at 3 43 05 p m

@AndreMarcel99 AndreMarcel99 changed the title Enabler/2142/update zos copy interface [Enabler][2142]update_zos_copy_interface Aug 8, 2025
@AndreMarcel99 AndreMarcel99 marked this pull request as ready for review August 8, 2025 21:43
Copy link
Collaborator

@richp405 richp405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some confusion/mixing of 'force' versus 'replace'. Int the comments, it looks like replace is gone, but in the code, it is still there. Can you clarify this?

@@ -0,0 +1,4 @@
breaking_changes:
- zos_copy - Option ``force_lock`` is deprecated in favor of ``force``. Option ``force`` is deprecated in favor of ``replace``.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a little awkward: force_lock->force->replace seems confusing. Why not reword as (force_lock and force are deprecated in favor of replace).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right.

@AndreMarcel99 AndreMarcel99 requested a review from richp405 August 11, 2025 15:13
Copy link
Collaborator

@fernandofloresg fernandofloresg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, left a minor comment of a typo fix. thanks for adding the new checks in the test assertions.

@fernandofloresg fernandofloresg merged commit 73190da into dev Aug 11, 2025
5 checks passed
@fernandofloresg fernandofloresg deleted the enabler/2142/update_zos_copy_interface branch August 11, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Update zos_copy module interface
3 participants