integrate simple vault transit auto-unseal support #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have no problem of taking your PR instead of mine, but note that the author demanded tests in order to merge this feature, so maybe we can work together on this so we can finally get this merged :) |
|
@FalcoSuessgott: Sorry, I have not seen yours else I would have tried it. Mine is more limited than your PR with one exception: it would use the same environment variables as the My needs are fulfilled, I just posted it here if someone is interested. I am fine to close it as duplicate. |
|
The PR #258 is merged. I'll hope to test that next week on my side. |
|
Please resolve conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to configure a Vault Transit Auto-Unseal as documented in