Skip to content

patch podman login: omit certdir by default #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

patch podman login: omit certdir by default #250

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01083d7
podman login: omit certdir value by default
dometto Mar 12, 2024
feee289
podman login: disable log
dometto Mar 12, 2024
a15c7e1
Bypass linter
dometto Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/molecule_plugins/podman/playbooks/create.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@
- name: Log into a container registry
containers.podman.podman_login:
certdir: >-
{% if lookup('env', 'DOCKER_CERT_PATH') %}
{{ item.cert_path | default(lookup('env', 'DOCKER_CERT_PATH') + '/cert.pem') }}
{% endif %}
{% if lookup('env', 'DOCKER_CERT_PATH') %}{{ item.cert_path | default(lookup('env', 'DOCKER_CERT_PATH') + '/cert.pem') }}{% else %}{{ item.cert_path | default(omit) }}{% endif %} # noqa yaml[line-length] jinja[spacing]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try with noqa: instead of noqa ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, why do you need to ignore the line-length ? I've not checked but the line is using '>-' so you should be able to split over the line the same way it was before your change. It would be easier to read and no error from the lint.

Side note: it would be interesting to check if it's possible to reproduce that linting issue and ask -lint developers as it would be surprising to not be able to ignore an error.

executable: "{{ podman_exec }}"
username: "{{ item.registry.credentials.username }}"
password: "{{ item.registry.credentials.password }}"
Expand All @@ -30,6 +28,7 @@
- item.registry.credentials is defined
- item.registry.credentials.username is defined
changed_when: false
no_log: true

- name: Check presence of custom Dockerfiles
ansible.builtin.stat:
Expand Down
Loading