chore: remove broken tests because of upstream changes in molecule#353
Open
ziegenberg wants to merge 1 commit intoansible-community:mainfrom
Open
chore: remove broken tests because of upstream changes in molecule#353ziegenberg wants to merge 1 commit intoansible-community:mainfrom
ziegenberg wants to merge 1 commit intoansible-community:mainfrom
Conversation
With PR #3959 in molecule[1], templating was re-implemented. This change had two major changes: - Removed the 'init role' command - Removed support for custom templating from drivers So we can safely remove the tests for driver-specific `molecule init role` and `molecule init scenario` commands. [1] ansible/molecule#3959 Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
There was a problem hiding this comment.
Pull request overview
This PR removes broken tests that depended on molecule's templating functionality which was removed in an upstream change. The upstream PR #3959 in molecule removed the 'init role' command and support for custom driver templating, making these tests obsolete.
Changes:
- Removed the
generate-templates.shscript and its usage from the tox lint configuration - Removed driver-specific
molecule init scenariotests from vagrant, podman, docker, gce, ec2, containers, and azure plugins - Cleaned up unused imports from test files after test removal
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/generate-templates.sh | Deleted script that generated test roles using molecule init commands |
| pyproject.toml | Removed generate-templates.sh script execution from tox lint environment |
| test/vagrant-plugin/functional/test_func.py | Removed test_vagrant_command_init_scenario test and unused vagrant import |
| test/podman/test_func.py | Removed test_podman_command_init_scenario test and unused imports |
| test/docker/test_func.py | Removed test_command_init_and_test_scenario test and unused imports |
| test/gce/functional/test_func.py | Deleted entire file containing only init scenario test |
| test/ec2/functional/test_ec2.py | Deleted entire file containing only init scenario test |
| test/containers/functional/test_containers.py | Deleted entire file containing only init scenario test |
| test/azure/functional/test_azure.py | Deleted entire file containing only init scenario test |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With PR #3959 in molecule, templating was re-implemented. This change had two major changes:
So we can safely remove the tests for driver-specific
molecule init roleandmolecule init scenariocommands.