Bridge L2PT Model Definition #303
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stalabi1
suggested changes
Apr 28, 2025
| type: list | ||
| elements: str | ||
| state: | ||
| description: |
There was a problem hiding this comment.
2 options: Add descriptions for replaced and overridden state since you have them for merged and deleted or simply just have '- The state of the configuration after module completion' for the description
| COPYRIGHT: Copyright 2025 Dell Inc. or its subsidiaries. All Rights Reserved. | ||
| DOCUMENTATION: | | ||
| module: sonic_br_l2pt | ||
| version_added: '3.1.0' |
There was a problem hiding this comment.
Suggested change
| version_added: '3.1.0' | |
| version_added: '3.1.0' | |
| notes: | |
| - Tested against Enterprise SONiC Distribution by Dell Technologies. | |
| - Supports C(check_mode). |
| required: true | ||
| choices: ['LLDP', 'LACP', 'STP', 'CDP'] | ||
| vlan_ids: | ||
| description: List of VLAN IDs on which the L2 Protocol packets are to be tunneled. |
There was a problem hiding this comment.
let the user know that a range can be specified in the list of vlan_ids and what delimiter it uses
stalabi1
reviewed
Apr 28, 2025
| @@ -0,0 +1,64 @@ | |||
| GENERATOR_VERSION: '1.0' | |||
| ANSIBLE_METADATA: | | |||
There was a problem hiding this comment.
Suggested change
| ANSIBLE_METADATA: | |
Remove the Ansible metadata stuff please.
stalabi1
approved these changes
May 5, 2025
stalabi1
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Bridge Layer 2 Protocol Tunneling model definition for SONiC.