Skip to content

Add missing no-fallback CSP directives (frame-ancestors, base-uri, etc.)#1979

Open
SiddharthRajaraman wants to merge 1 commit intomainfrom
srajaram/aap-64625-define-directive
Open

Add missing no-fallback CSP directives (frame-ancestors, base-uri, etc.)#1979
SiddharthRajaraman wants to merge 1 commit intomainfrom
srajaram/aap-64625-define-directive

Conversation

@SiddharthRajaraman
Copy link
Contributor

Jira Issue: https://issues.redhat.com/browse/AAP-64625

Assisted-by: CursorAI

Description

Adds missing CSP directives that have no fallback to default-src: frame-ancestors, base-uri, and form-action. Without these, the directives are effectively unset, allowing unrestricted behavior. Resolves RapidAST DAST finding 10055-13

Testing

Steps to test

  1. Pull down the PR
  2. Run TestUrls tests
  3. Make sure all pass

Type of Change

  • Bug fix (non-breaking change fixing an issue)
  • New feature (non-breaking change adding functionality)
  • Breaking change (fix or feature causing existing functionality to break)
  • Security fix
  • Performance improvement
  • Code refactoring
  • Documentation update
  • CI/CD update

Backport Policy

This change should be:

  • Not backported - main/master only
  • Backported to specific releases (add labels after merge)

Automated Backport Instructions

After this PR is merged, add one or more labels to automatically create backport PRs:

  • backport/stable-2.4 - Backport to stable-2.4 branch
  • backport/stable-2.5 - Backport to stable-2.5 branch
  • backport/stable-2.6 - Backport to stable-2.6 branch
  • backport/all - Backport to all active stable branches
  • no-backport - Explicitly mark as not needing backport

Backport Justification

Special backport considerations:

Scenarios tested

Production deployment

  • This code change is ready for production on its own
  • This code change requires the following considerations before going to production:

@SiddharthRajaraman SiddharthRajaraman force-pushed the srajaram/aap-64625-define-directive branch from 7276da5 to d5c36d5 Compare March 12, 2026 15:36
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant