forked from road-core/service
-
Notifications
You must be signed in to change notification settings - Fork 7
Add e2e test pipeline for triggering the e2e tests of the project #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mabulgu
wants to merge
15
commits into
main
Choose a base branch
from
story/AAP-37403
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
cf89034
add the konflux build for PR
mabulgu c9e8a94
implement the push pipeline
mabulgu c93b6f1
Customize package for aap (#20)
jameswnl 3fb2b3b
production target for building image (#21)
jameswnl e51bb0f
Script to build ansible-chatbot-service image locally
TamiTakamiya ef60988
Modify AAP system prompt to include the latest AAP version instead of…
TamiTakamiya a301174
Allocate more memory to clair-scan step
TamiTakamiya 0628df1
Update Konflux references (#23)
red-hat-konflux[bot] 81873c6
Update dependency distlib to v0.3.9
red-hat-konflux[bot] 2b57935
Move RAG image to Ansible repository
TamiTakamiya 721e8ab
Merge pull request #37 from ansible/TamiTakamiya/AAP-34876/move-rag-i…
TamiTakamiya 4b1c0f8
Merge branch 'main' into konflux/mintmaker/main/distlib-0.x
TamiTakamiya 55c648b
Merge pull request #36 from ansible/konflux/mintmaker/main/distlib-0.x
TamiTakamiya b857e13
add e2e test pipeline
mabulgu 3a80cd0
add environment as input parameter
mabulgu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
name: E2E tests | ||
|
||
on: | ||
workflow_dispatch: | ||
inputs: | ||
branch: | ||
description: 'branch to run tests from, default: main' | ||
required: false | ||
type: string | ||
environment: | ||
type: choice | ||
description: Environment | ||
options: | ||
- stage | ||
- prod | ||
|
||
env: | ||
branch: ${{ inputs.branch || 'main' }} | ||
ols_url: ${{ inputs.environment == 'stage' && 'https://stage.ai.ansible.redhat.com/chat' || 'https://c.ai.ansible.redhat.com/chat' }} | ||
|
||
jobs: | ||
test_schedule: | ||
timeout-minutes: 30 | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout ${{ env.branch }} | ||
uses: actions/checkout@v3 | ||
with: | ||
ref: ${{ env.branch }} | ||
|
||
- name: Set up python3 | ||
uses: actions/setup-python@v5 | ||
with: | ||
python-version: '3.11' | ||
|
||
- name: Python version | ||
run: python --version | ||
|
||
- name: PDM installation | ||
run: pip install --user pdm | ||
|
||
- name: Install dependencies | ||
run: pdm install | ||
|
||
- name: Install devel dependencies | ||
run: pdm install --dev | ||
|
||
- name: Run e2e tests | ||
run: OLS_URL=${{ env.ols_url }} pdm run python -m pytest -m tests/e2e --doctest-modules --junitxml=junit/e2e-test-results.xml | ||
|
||
- name: Upload pytest test results | ||
uses: actions/upload-artifact@v4 | ||
with: | ||
name: e2e-test-results | ||
path: junit/e2e-test-results.xml | ||
# Use always() to always run this step to publish test results when there are test failures | ||
if: ${{ always() }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -63,4 +63,4 @@ woke | |
benchmark_*.svg | ||
|
||
# requirements file | ||
requirements* | ||
# requirements* |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dear reviewer, please consider this:
For the URLs here I used the ai connect chat urls but what we need here is the exposed urls of the chatbot service itself. if these current URLs give us what we need right now then it should be enough but otherwise for running the e2e tests as designed we need a route for each environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this is sth we can discuss only when @TamiTakamiya returns, what I suggest is: let's merge this PR and that way we will be able to merge: https://github.com/ansible/ansible-wisdom-ops/pull/1179 and https://github.com/ansible/ansible-wisdom-ops/pull/1180
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jameswnl ^^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't expose the chatbot service to the public. so only though the wisdom-service