Skip to content

Remove ansible-test sanity from local module development #2034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samccann merged 2 commits into from
Oct 24, 2024
Merged

Remove ansible-test sanity from local module development #2034

samccann merged 2 commits into from
Oct 24, 2024

Conversation

@samccann
Copy link
Contributor

@samccann samccann commented Oct 17, 2024

Rumor has it this test doesn't apply to local modules (those not in core or in a collection).

Fixed a couple of other nits as well.

@samccann
Copy link
Contributor Author

samccann commented Oct 17, 2024

@mattclay - this came up in matrix. Wanted to verify with you that ansible-test sanity isn't meant for local modules..

...or if it is... got any idea how to make it work, cuz the current docs don't work :-)

@samccann samccann added backport-2.15 backport-2.18 Automatically create a backport for the stable-2.18 branch labels Oct 17, 2024
@mattclay
Copy link
Member

mattclay commented Oct 17, 2024

The only use cases supported by ansible-test are working on ansible-core and collections. It it does not support standalone roles or other project structures.

@oraNod oraNod added the backport-2.17 Automatically create a backport for the stable-2.17 branch label Oct 18, 2024
s-hertel
s-hertel reviewed Oct 18, 2024
View reviewed changes
samccann
samccann commented Oct 21, 2024
View reviewed changes
@samccann samccann merged commit ef72400 into ansible:devel Oct 24, 2024
10 checks passed
@patchback
Copy link

patchback bot commented Oct 24, 2024 •
edited
Loading

Backport to stable-2.15: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.15/ef72400cc2f70f974ffbb30b63098b31dbd36b07/pr-2034

Backported as #2056

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@samccann samccann deleted the fix-module-nits branch October 24, 2024 19:00
patchback bot pushed a commit that referenced this pull request Oct 24, 2024
@samccann @patchback
Remove ansible-test sanity from local module development (#2034)
cea2e72 
* Remove ansible-test sanity from local module development

* Update docs/docsite/rst/dev_guide/developing_modules_general.rst

(cherry picked from commit ef72400)
@patchback patchback bot mentioned this pull request Oct 24, 2024
Merged
@patchback
Copy link

patchback bot commented Oct 24, 2024 •
edited
Loading

Backport to stable-2.16: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.16/ef72400cc2f70f974ffbb30b63098b31dbd36b07/pr-2034

Backported as #2057

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 24, 2024
@samccann @patchback
Remove ansible-test sanity from local module development (#2034)
20cd7a6 
* Remove ansible-test sanity from local module development

* Update docs/docsite/rst/dev_guide/developing_modules_general.rst

(cherry picked from commit ef72400)
@patchback patchback bot mentioned this pull request Oct 24, 2024
Merged
@patchback
Copy link

patchback bot commented Oct 24, 2024 •
edited
Loading

Backport to stable-2.17: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.17/ef72400cc2f70f974ffbb30b63098b31dbd36b07/pr-2034

Backported as #2060

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 24, 2024
@samccann @patchback
Remove ansible-test sanity from local module development (#2034)
b3392e7 
* Remove ansible-test sanity from local module development

* Update docs/docsite/rst/dev_guide/developing_modules_general.rst

(cherry picked from commit ef72400)
@patchback patchback bot mentioned this pull request Oct 24, 2024
Merged
@patchback
Copy link

patchback bot commented Oct 24, 2024 •
edited
Loading

Backport to stable-2.18: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.18/ef72400cc2f70f974ffbb30b63098b31dbd36b07/pr-2034

Backported as #2061

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 24, 2024
@samccann @patchback
Remove ansible-test sanity from local module development (#2034)
ce485a8 
* Remove ansible-test sanity from local module development

* Update docs/docsite/rst/dev_guide/developing_modules_general.rst

(cherry picked from commit ef72400)
@patchback patchback bot mentioned this pull request Oct 24, 2024
Merged
samccann added a commit that referenced this pull request Oct 24, 2024
@patchback @samccann
Remove ansible-test sanity from local module development (#2034) (#2061)
2499b71 
* Remove ansible-test sanity from local module development

* Update docs/docsite/rst/dev_guide/developing_modules_general.rst

(cherry picked from commit ef72400)

Co-authored-by: Sandra McCann <[email protected]>
samccann added a commit that referenced this pull request Oct 24, 2024
@patchback @samccann
Remove ansible-test sanity from local module development (#2034) (#2060)
8edeb11 
* Remove ansible-test sanity from local module development

* Update docs/docsite/rst/dev_guide/developing_modules_general.rst

(cherry picked from commit ef72400)

Co-authored-by: Sandra McCann <[email protected]>
samccann added a commit that referenced this pull request Oct 24, 2024
@patchback @samccann
Remove ansible-test sanity from local module development (#2034) (#2057)
915c9dc 
* Remove ansible-test sanity from local module development

* Update docs/docsite/rst/dev_guide/developing_modules_general.rst

(cherry picked from commit ef72400)

Co-authored-by: Sandra McCann <[email protected]>
samccann added a commit that referenced this pull request Oct 24, 2024
@patchback @samccann
Remove ansible-test sanity from local module development (#2034) (#2056)
4f2c45b 
* Remove ansible-test sanity from local module development

* Update docs/docsite/rst/dev_guide/developing_modules_general.rst

(cherry picked from commit ef72400)

Co-authored-by: Sandra McCann <[email protected]>
oraNod pushed a commit that referenced this pull request Nov 25, 2024
@samccann @oraNod
Remove ansible-test sanity from local module development (#2034)
4076727 
* Remove ansible-test sanity from local module development

* Update docs/docsite/rst/dev_guide/developing_modules_general.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@s-hertel s-hertel s-hertel left review comments

Assignees

No one assigned

Labels

backport-2.17 Automatically create a backport for the stable-2.17 branch backport-2.18 Automatically create a backport for the stable-2.18 branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@samccann @mattclay @s-hertel @oraNod